linux-kernel - Re: [PATCH v2] vgem: fix error return in vgem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1afdfccc-04f1-4f82-a1bf-bf93df42af29@web.de>
Date: Fri, 3 Oct 2025 16:42:11 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Alexandr Sapozhnikov <alsp705@...il.com>,
 dri-devel@...ts.freedesktop.org, lvc-project@...uxtesting.org
Cc: LKML <linux-kernel@...r.kernel.org>, Daniel Vetter <daniel@...ll.ch>,
 David Airlie <airlied@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH v2] vgem: fix error return in vgem_init()

> The dma_coerce_mask_and_coherent function may 
> fail to apply a mask due to incorrectly passed parameters. 
…

* You may occasionally put more than 61 characters into text lines
  of such a change description.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n658

* Would you like to choose another imperative wording?

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

…
> ---
>  drivers/gpu/drm/vgem/vgem_drv.c | 4 +++-
…

Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22

…
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -140,8 +140,10 @@ static int __init vgem_init(void)
>  		goto out_unregister;
>  	}
>  
> -	dma_coerce_mask_and_coherent(&pdev->dev,
> +	ret = dma_coerce_mask_and_coherent(&pdev->dev,
>  				     DMA_BIT_MASK(64));
> +	if (ret)
> +		goto out_unregister;
…

I suggest to keep the passed parameters in the same line for this function call.

Regards,
Markus