linux-kernel - Re: [PATCH] kdb: delete unexecuted if-block in kdb_get_kbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=V4hRA8WnvxYNgXsULrzOTCdXZ9JMHgZ=XxqpVZz5DNOQ@mail.gmail.com>
Date: Fri, 3 Oct 2025 09:39:33 -0700
From: Doug Anderson <dianders@...omium.org>
To: Matvey Kovalev <matvey.kovalev@...ras.ru>
Cc: Jason Wessel <jason.wessel@...driver.com>, Daniel Thompson <danielt@...nel.org>, 
	kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] kdb: delete unexecuted if-block in kdb_get_kbd_char()

Hi,

On Fri, Oct 3, 2025 at 8:13 AM Matvey Kovalev <matvey.kovalev@...ras.ru> wrote:
>
> Bits of scancode are dropped except 7 low-order ones.
> So, scancode can't be equal 0xe0.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Matvey Kovalev <matvey.kovalev@...ras.ru>
> ---
>  kernel/debug/kdb/kdb_keyboard.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_keyboard.c b/kernel/debug/kdb/kdb_keyboard.c
> index 3a74604fdb8a7..386d30e530b78 100644
> --- a/kernel/debug/kdb/kdb_keyboard.c
> +++ b/kernel/debug/kdb/kdb_keyboard.c
> @@ -145,9 +145,6 @@ int kdb_get_kbd_char(void)
>                 return CTRL('F');
>         }
>
> -       if (scancode == 0xe0)
> -               return -1;
> -

The same patch has already been sent and was landed:

https://lore.kernel.org/all/20250507104337.201695-1-colin.i.king@gmail.com/