| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202510040111.2VVT6u6C-lkp@intel.com>
Date: Sat, 4 Oct 2025 01:36:31 +0800
From: kernel test robot <lkp@...el.com>
To: CL Wang <cl634@...estech.com>, vkoul@...nel.org,
dmaengine@...r.kernel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
tim609@...estech.com
Subject: Re: [PATCH V1 2/2] dmaengine: atcdmac300: Add driver for Andes
ATCDMAC300 DMA controller
Hi CL,
kernel test robot noticed the following build warnings:
[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on linus/master v6.17 next-20251003]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/CL-Wang/dt-bindings-dmaengine-Add-support-for-ATCDMAC300-DMA-engine/20251002-212152
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link: https://lore.kernel.org/r/20251002131659.973955-3-cl634%40andestech.com
patch subject: [PATCH V1 2/2] dmaengine: atcdmac300: Add driver for Andes ATCDMAC300 DMA controller
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20251004/202510040111.2VVT6u6C-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 39f292ffa13d7ca0d1edff27ac8fd55024bb4d19)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251004/202510040111.2VVT6u6C-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510040111.2VVT6u6C-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from <built-in>:3:
In file included from include/linux/compiler_types.h:171:
include/linux/compiler-clang.h:28:9: warning: '__SANITIZE_ADDRESS__' macro redefined [-Wmacro-redefined]
28 | #define __SANITIZE_ADDRESS__
| ^
<built-in>:371:9: note: previous definition is here
371 | #define __SANITIZE_ADDRESS__ 1
| ^
>> drivers/dma/atcdmac300.c:772:9: warning: variable 'total_len' set but not used [-Wunused-but-set-variable]
772 | size_t total_len = 0;
| ^
drivers/dma/atcdmac300.c:887:9: warning: variable 'total_len' set but not used [-Wunused-but-set-variable]
887 | size_t total_len = 0;
| ^
3 warnings generated.
--
>> Warning: drivers/dma/atcdmac300.c:695 function parameter 'dst' not described in 'atcdmac_prep_dma_memcpy'
vim +/total_len +772 drivers/dma/atcdmac300.c
676
677 /**
678 * atcdmac_prep_dma_memcpy - Prepare a DMA memcpy operation for the specified
679 * channel
680 * @chan: DMA channel to configure for the operation
681 * @dest: Physical destination address for the transfer
682 * @src: Physical source address for the transfer
683 * @len: Size of the data to transfer, in bytes
684 * @flags: Status flags for the transfer descriptor
685 *
686 * This function sets up a DMA memcpy operation to transfer data from the
687 * specified source address to the destination address. It returns a DMA
688 * descriptor that represents the configured transaction.
689 */
690 static struct dma_async_tx_descriptor *
691 atcdmac_prep_dma_memcpy(struct dma_chan *chan,
692 dma_addr_t dst,
693 dma_addr_t src,
694 size_t len,
> 695 unsigned long flags)
696 {
697 struct atcdmac_chan *dmac_chan = atcdmac_chan_to_dmac_chan(chan);
698 struct atcdmac_dmac *dmac = atcdmac_dev_to_dmac(chan->device);
699 struct atcdmac_desc *desc;
700 unsigned int src_width;
701 unsigned int dst_width;
702 unsigned int ctrl;
703 unsigned char src_max_burst;
704
705 if (unlikely(!len)) {
706 dev_warn(atcdmac_chan_to_dev(chan),
707 "Failed to prepare DMA operation: len is zero\n");
708 return NULL;
709 }
710
711 if (dmac->regmap_iocp) {
712 dst |= IOCP_MASK;
713 src |= IOCP_MASK;
714 }
715 src_max_burst =
716 atcdmac_convert_burst((unsigned int)SRC_BURST_SIZE_1024);
717 src_width = atcdmac_map_tran_width(src,
718 dst,
719 len,
720 1 << dmac->data_width);
721 dst_width = src_width;
722 ctrl = SRC_BURST_SIZE(src_max_burst) |
723 SRC_ADDR_MODE_INCR |
724 DST_ADDR_MODE_INCR |
725 DST_WIDTH(dst_width) |
726 SRC_WIDTH(src_width);
727
728 desc = atcdmac_build_desc(dmac_chan, src, dst, ctrl,
729 len >> src_width, 1);
730 if (!desc)
731 goto err_desc_get;
732
733 return &desc->txd;
734
735 err_desc_get:
736 dev_warn(atcdmac_chan_to_dev(chan), "Failed to allocate descriptor\n");
737 return NULL;
738 }
739
740 /**
741 * atcdmac_prep_device_sg - Prepare descriptors for memory/device DMA
742 * transactions
743 * @chan: DMA channel to configure for the operation
744 * @sgl: Scatter-gather list representing the memory regions to transfer
745 * @sg_len: Number of entries in the scatter-gather list
746 * @direction: Direction of the DMA transfer
747 * @flags: Status flags for the transfer descriptor
748 * @context: transaction context (ignored)
749 *
750 * This function prepares a DMA transaction by setting up the required
751 * descriptors based on the provided scatter-gather list and parameters.
752 * It supports memory-to-device and device-to-memory DMA transfers.
753 */
754 static struct dma_async_tx_descriptor *
755 atcdmac_prep_device_sg(struct dma_chan *chan,
756 struct scatterlist *sgl,
757 unsigned int sg_len,
758 enum dma_transfer_direction direction,
759 unsigned long flags,
760 void *context)
761 {
762 struct atcdmac_dmac *dmac = atcdmac_dev_to_dmac(chan->device);
763 struct atcdmac_chan *dmac_chan = atcdmac_chan_to_dmac_chan(chan);
764 struct dma_slave_config *sconfig = &dmac_chan->dma_sconfig;
765 struct atcdmac_desc *first;
766 struct scatterlist *sg;
767 dma_addr_t reg;
768 unsigned int i;
769 unsigned int width_src;
770 unsigned int width_dst;
771 unsigned short burst_bytes;
> 772 size_t total_len = 0;
773
774 if (unlikely(!sg_len)) {
775 dev_warn(atcdmac_chan_to_dev(chan), "sg_len is zero\n");
776 return NULL;
777 }
778
779 if (direction == DMA_MEM_TO_DEV) {
780 reg = sconfig->dst_addr;
781 burst_bytes = sconfig->dst_addr_width * sconfig->dst_maxburst;
782 width_dst = atcdmac_map_buswidth(sconfig->dst_addr_width);
783 width_src = atcdmac_map_buswidth(sconfig->src_addr_width);
784 } else if (direction == DMA_DEV_TO_MEM) {
785 reg = sconfig->src_addr;
786 burst_bytes = sconfig->src_addr_width * sconfig->src_maxburst;
787 width_src = atcdmac_map_buswidth(sconfig->src_addr_width);
788 width_dst = atcdmac_map_buswidth(sconfig->dst_addr_width);
789 } else {
790 dev_info(atcdmac_chan_to_dev(chan),
791 "Invalid transfer direction %d\n", direction);
792 return NULL;
793 }
794
795 for_each_sg(sgl, sg, sg_len, i) {
796 struct atcdmac_desc *prev, *desc;
797 dma_addr_t mem;
798 dma_addr_t src, dst;
799 unsigned int width_cal;
800 unsigned int len;
801 unsigned int ctrl;
802 unsigned short burst_size;
803
804 mem = sg_dma_address(sg);
805 len = sg_dma_len(sg);
806 if (unlikely(!len)) {
807 dev_info(atcdmac_chan_to_dev(chan),
808 "sg(%u) data len is zero\n", i);
809 goto err;
810 }
811
812 if (dmac->regmap_iocp)
813 mem |= IOCP_MASK;
814
815 width_cal = atcdmac_map_tran_width(mem,
816 reg,
817 len,
818 (1 << dmac->data_width) |
819 burst_bytes);
820 if (direction == DMA_MEM_TO_DEV) {
821 if (burst_bytes < (1 << width_cal)) {
822 burst_size = burst_bytes;
823 width_cal = WIDTH_1_BYTE;
824 } else {
825 burst_size = burst_bytes / (1 << width_cal);
826 }
827
828 ctrl = SRC_ADDR_MODE_INCR | DST_ADDR_MODE_FIXED |
829 DST_HS | DST_REQ(dmac_chan->req_num) |
830 SRC_WIDTH(width_cal) | DST_WIDTH(width_dst) |
831 SRC_BURST_SIZE(ilog2(burst_size));
832 src = mem;
833 dst = reg;
834 } else {
835 burst_size = burst_bytes / sconfig->src_addr_width;
836
837 ctrl = SRC_ADDR_MODE_FIXED | DST_ADDR_MODE_INCR |
838 SRC_HS | SRC_REQ(dmac_chan->req_num) |
839 SRC_WIDTH(width_src) | DST_WIDTH(width_cal) |
840 SRC_BURST_SIZE(ilog2(burst_size));
841 src = reg;
842 dst = mem;
843 width_cal = width_src;
844 }
845
846 desc = atcdmac_build_desc(dmac_chan, src, dst, ctrl,
847 len >> width_cal, sg_len);
848 if (!desc)
849 goto err_desc_get;
850
851 atcdmac_chain_desc(&first, &prev, desc, false);
852 total_len += len;
853 }
854
855 first->txd.cookie = -EBUSY;
856 first->txd.flags = flags;
857
858 return &first->txd;
859
860 err_desc_get:
861 dev_warn(atcdmac_chan_to_dev(chan), "Failed to allocate descriptor\n");
862
863 err:
864 if (first)
865 atcdmac_put_desc(dmac_chan, first);
866 return NULL;
867 }
868
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists