linux-kernel - Re: [PATCH] driver core: fw_devlink: Don't warn in fw_devlink_dev_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DD8WBG9LXET7.189BAJGVYEOIR@cknow.org>
Date: Fri, 03 Oct 2025 20:24:22 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Diederik de Haas" <didi.debian@...ow.org>, "Ulf Hansson"
 <ulf.hansson@...aro.org>, "Saravana Kannan" <saravanak@...gle.com>, "Rafael
 J . Wysocki" <rafael@...nel.org>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>, <linux-pm@...r.kernel.org>
Cc: "Geert Uytterhoeven" <geert@...ux-m68k.org>, "Nicolas Frattaroli"
 <nicolas.frattaroli@...labora.com>, "Heiko Stuebner" <heiko@...ech.de>,
 "Sebastian Reichel" <sebastian.reichel@...labora.com>, "Sebin Francis"
 <sebin.francis@...com>, "Tomi Valkeinen" <tomi.valkeinen@...asonboard.com>,
 "Jon Hunter" <jonathanh@...dia.com>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] driver core: fw_devlink: Don't warn in
 fw_devlink_dev_sync_state()

On Thu Sep 25, 2025 at 3:59 PM CEST, Diederik de Haas wrote:
> On Fri Sep 12, 2025 at 8:32 PM CEST, Saravana Kannan wrote:
>> Please don't just disable fw_devlink using fw_devlink=off. We want to
>> fix any issues you are hitting with it. I might even delete this "off"
>> option sometime. It was meant as an early debug option.
>
> I want to test all my (Rockchip) devices to see if they 'need'
> that parameter to 'silence' the warning. I have a (vague) recollection
> that some don't need it (for that).

Not trying to revisit the discussion, only to report that data.
All tests were done with the 6.17 kernel and no 'fw_devlink=off'.

Device				sync_state warning
Rock64 (rk3328)			yes
RockPro64 (rk3399)		no
Quartz64 Model A (rk3566)	no
Quartz64 Model B (rk3566)	yes
PineTab2 (rk3566)		yes
NanoPi R5S (rk3568)		yes
Rock 5B (rk3588)		yes

Cheers,
  Diederik

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)