linux-kernel - Re: [PATCH next] PM: runtime: Fix error checking for kunit_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gtJjtf=YyprzEMUrYi0336nNPNkMFJeE-3+06Trv7M6A@mail.gmail.com>
Date: Fri, 3 Oct 2025 21:14:13 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Brian Norris <briannorris@...omium.org>, Dan Carpenter <dan.carpenter@...aro.org>
Cc: Pavel Machek <pavel@...nel.org>, Len Brown <lenb@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Danilo Krummrich <dakr@...nel.org>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] PM: runtime: Fix error checking for kunit_device_register()

On Fri, Oct 3, 2025 at 7:02 PM Brian Norris <briannorris@...omium.org> wrote:
>
> On Fri, Oct 03, 2025 at 12:29:31PM +0300, Dan Carpenter wrote:
> > The kunit_device_register() function never returns NULL, it returns
> > error pointers.  Update the assertions to use
> > KUNIT_ASSERT_NOT_ERR_OR_NULL() instead of checking for NULL.
> >
> > Fixes: 7f7acd193ba8 ("PM: runtime: Add basic kunit tests for API contracts")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
>
> Thanks for the catch:
>
> Reviewed-by: Brian Norris <briannorris@...omium.org>

Applied, thanks!