linux-kernel - Re: [PATCH v1] perf build: Move libopcode disasm tests to BUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aOAhmqTtuk5KrYcy@x1>
Date: Fri, 3 Oct 2025 16:18:50 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf build: Move libopcode disasm tests to
 BUILD_NONDISTRO

On Thu, Oct 02, 2025 at 07:39:28PM -0700, Ian Rogers wrote:
> The disasm feature tests feature-disassembler-four-args and
> feature-disassembler-init-styled link against libopcodes part of
> binutils which is license incompatible (GPLv3) with perf. Moving these
> tests out of the common config will help improve build time.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/Makefile.config | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 6e7c057b8ecf..0d4a62869855 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -933,6 +933,14 @@ ifdef BUILD_NONDISTRO
>    else
>      $(warning Old version of libbfd/binutils things like PE executable profiling will not be available)
>    endif
> +
> +  ifeq ($(feature-disassembler-four-args), 1)
> +    CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE
> +  endif
> +
> +  ifeq ($(feature-disassembler-init-styled), 1)
> +    CFLAGS += -DDISASM_INIT_STYLED
> +  endif
>  endif
>  
>  ifndef NO_LIBLLVM
> @@ -1024,14 +1032,6 @@ ifdef HAVE_KVM_STAT_SUPPORT
>      CFLAGS += -DHAVE_KVM_STAT_SUPPORT
>  endif
>  
> -ifeq ($(feature-disassembler-four-args), 1)
> -    CFLAGS += -DDISASM_FOUR_ARGS_SIGNATURE
> -endif
> -
> -ifeq ($(feature-disassembler-init-styled), 1)
> -    CFLAGS += -DDISASM_INIT_STYLED
> -endif
> -
>  ifeq (${IS_64_BIT}, 1)
>    ifndef NO_PERF_READ_VDSO32
>      $(call feature_check,compile-32)
> -- 
> 2.51.0.618.g983fd99d29-goog