linux-kernel - Re: [PATCH v2 2/2] tools build: Remove get_current_dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAP-5=fXVVg5BC-q85i4s8Phdp86UYEKTaKHcb75W76LdSa+_7g@mail.gmail.com>
Date: Fri, 3 Oct 2025 14:29:09 -0700
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Namhyung Kim <namhyung@...nel.org>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, linux-kernel@...r.kernel.org, 
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 2/2] tools build: Remove get_current_dir_name

On Fri, Oct 3, 2025 at 12:48 PM Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
>
> On Fri, Oct 03, 2025 at 10:56:13AM -0700, Ian Rogers wrote:
> > As perf no longer tests for this feature, and it was the only user,
> > remove the feature test.
>
> You forgot to remove this:
>
> ⬢ [acme@...lbx perf-tools-next]$ git diff
> diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
> index 71ba7001dc25c6bb..8a354b81417c6fcc 100644
> --- a/tools/build/feature/test-all.c
> +++ b/tools/build/feature/test-all.c
> @@ -151,7 +151,6 @@ int main(int argc, char *argv[])
>         main_test_libpython();
>         main_test_hello();
>         main_test_libelf();
> -       main_test_get_current_dir_name();
>         main_test_gettid();
>         main_test_glibc();
>         main_test_libdw();
> ⬢ [acme@...lbx perf-tools-next]$
>
> That results, when building with this alias:
>
> alias m='rm -rf ~/libexec/perf-core/ ; make CORESIGHT=1 -k O=/tmp/build/$(basename $PWD)/ -C tools/perf install-bin && perf test python && cat /tmp/build/$(basename $PWD)/feature/test-all.make.output'
>
> that needs to be on the makefiles somewhere, shows that test-all.bin is
> failing to build:
>
> make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf'
>  88: 'import perf' in python                                         : FAILED!
> test-all.c: In function ‘main’:
> test-all.c:154:9: error: implicit declaration of function ‘main_test_get_current_dir_name’; did you mean ‘get_current_dir_name’? [-Wimplicit-function-declaration]
>   154 |         main_test_get_current_dir_name();
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |         get_current_dir_name
> ⬢ [acme@...lbx perf-tools-next]$
>
> I fixed this up already,

Sorry for that. Thanks for fixing it up!
Ian

> Thanks,
>
> - Arnaldo
>
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > ---
> >  tools/build/Makefile.feature                    |  1 -
> >  tools/build/feature/Makefile                    |  4 ----
> >  tools/build/feature/test-all.c                  |  4 ----
> >  tools/build/feature/test-get_current_dir_name.c | 11 -----------
> >  4 files changed, 20 deletions(-)
> >  delete mode 100644 tools/build/feature/test-get_current_dir_name.c
> >
> > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > index 9c1a69d26f51..9399f591bd69 100644
> > --- a/tools/build/Makefile.feature
> > +++ b/tools/build/Makefile.feature
> > @@ -68,7 +68,6 @@ FEATURE_TESTS_BASIC :=                  \
> >          libdw                           \
> >          eventfd                         \
> >          fortify-source                  \
> > -        get_current_dir_name            \
> >          gettid                               \
> >          glibc                           \
> >          libbfd                          \
> > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
> > index b41a42818d8a..d13d2a1f44fe 100644
> > --- a/tools/build/feature/Makefile
> > +++ b/tools/build/feature/Makefile
> > @@ -8,7 +8,6 @@ FILES=                                          \
> >           test-libdw.bin                         \
> >           test-eventfd.bin                       \
> >           test-fortify-source.bin                \
> > -         test-get_current_dir_name.bin          \
> >           test-glibc.bin                         \
> >           test-gtk2.bin                          \
> >           test-gtk2-infobar.bin                  \
> > @@ -147,9 +146,6 @@ $(OUTPUT)test-libelf.bin:
> >  $(OUTPUT)test-eventfd.bin:
> >       $(BUILD)
> >
> > -$(OUTPUT)test-get_current_dir_name.bin:
> > -     $(BUILD)
> > -
> >  $(OUTPUT)test-glibc.bin:
> >       $(BUILD)
> >
> > diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c
> > index e1847db6f8e6..778883a32afb 100644
> > --- a/tools/build/feature/test-all.c
> > +++ b/tools/build/feature/test-all.c
> > @@ -22,10 +22,6 @@
> >  # include "test-libelf.c"
> >  #undef main
> >
> > -#define main main_test_get_current_dir_name
> > -# include "test-get_current_dir_name.c"
> > -#undef main
> > -
> >  #define main main_test_gettid
> >  # include "test-gettid.c"
> >  #undef main
> > diff --git a/tools/build/feature/test-get_current_dir_name.c b/tools/build/feature/test-get_current_dir_name.c
> > deleted file mode 100644
> > index c3c201691b4f..000000000000
> > --- a/tools/build/feature/test-get_current_dir_name.c
> > +++ /dev/null
> > @@ -1,11 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > -#define _GNU_SOURCE
> > -#include <unistd.h>
> > -#include <stdlib.h>
> > -
> > -int main(void)
> > -{
> > -     free(get_current_dir_name());
> > -     return 0;
> > -}
> > -#undef _GNU_SOURCE
> > --
> > 2.51.0.618.g983fd99d29-goog