[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5xsdio5efpcpwpqek6e7tdk5kdr2f3xogne2iyhdl5ra2aqamu@icnfajxxnlq5>
Date: Sat, 4 Oct 2025 00:49:17 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Paul Sajna <sajattack@...tmarketos.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, David Heidelberg <david@...t.cz>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
Amir Dahan <system64fumo@...tonmail.com>,
Christopher Brown <crispybrown@...il.com>
Subject: Re: [PATCH v3 06/11] arm64: dts: qcom: sdm845-lg-judyln: Add
firmware nodes, change path
On Sun, Sep 28, 2025 at 10:05:29PM -0700, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, bluetooth, venus, gpu
>
> Enable adsp and cdsp nodes since their firmware is present
>
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
>
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.
>
> Paths changed to qcom/sdm845/lg/judyln
>
> Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 26 +++++++++++++++++---------
> 2 files changed, 27 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index aa338612433f9ac3b07363b79d8a3b8e0eedd98b..0f0a3f471f48e26cc48feb1551093599fcb35d7f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -173,6 +173,10 @@ &adsp_pas {
> status = "okay";
> };
>
> +&cdsp_pas {
> + status = "okay";
> +};
Please move it down. Also please check the order of other nodes in the
patch.
> +
> @@ -137,9 +141,13 @@ sde_te_sleep: sde-te-sleep-state {
> };
>
> &bluetooth {
> - /*
> - * This path is relative to the qca/
> - * subdir under lib/firmware.
> - */
> - firmware-name = "judyln/crnv21.bin";
> +/*
> + * This path is relative to the qca/
> + * subdir under lib/firmware.
> + */
What happened? this should be a part of the earlier patch.
> + firmware-name = "judyln/crnv21.bin";
> +};
> +
> +&venus {
> + firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
> };
>
> --
> 2.51.0
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists