linux-kernel - Re: [PATCH] iio: adc: stm32-dfsdm: fix st,adc-alt-channel property handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251004142517.0cf3e7a2@jic23-huawei>
Date: Sat, 4 Oct 2025 14:25:17 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Olivier Moysan <olivier.moysan@...s.st.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá	 <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Maxime Coquelin	 <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: stm32-dfsdm: fix st,adc-alt-channel property
 handling

On Fri, 03 Oct 2025 07:15:56 +0100
Nuno Sá <noname.nuno@...il.com> wrote:

> On Thu, 2025-10-02 at 13:22 +0200, Olivier Moysan wrote:
> > Initially st,adc-alt-channel property was defined as an enum in the DFSDM
> > binding. The DFSDM binding has been changed to use the new IIO backend
> > framework, along with the adoption of IIO generic channels.
> > In this new binding st,adc-alt-channel is defined as a boolean property,
> > but it is still handled has an enum in DFSDM driver.
> > Fix st,adc-alt-channel property handling in DFSDM driver.
> > 
> > Fixes: 3208fa0cd919 ("iio: adc: stm32-dfsdm: adopt generic channels bindings")
> > Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
Applied to my temporary fixes branch that I'll rebase on rc1 once available.
Also marked for stable.

thanks,

Jonathan

> 
> >  drivers/iio/adc/stm32-dfsdm-adc.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> > index 74b1b4dc6e81..9664b9bd75d4 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> > @@ -725,9 +725,8 @@ static int stm32_dfsdm_generic_channel_parse_of(struct
> > stm32_dfsdm *dfsdm,
> >  	}
> >  	df_ch->src = val;
> >  
> > -	ret = fwnode_property_read_u32(node, "st,adc-alt-channel", &df_ch-  
> > >alt_si);  
> > -	if (ret != -EINVAL)
> > -		df_ch->alt_si = 0;
> > +	if (fwnode_property_present(node, "st,adc-alt-channel"))
> > +		df_ch->alt_si = 1;
> >  
> >  	if (adc->dev_data->type == DFSDM_IIO) {
> >  		backend = devm_iio_backend_fwnode_get(&indio_dev->dev, NULL,
> > node);