linux-kernel - Re: [PATCH v2] drm/gud: Use kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d957bb721c9039287833ca0a9e2cebd60943c5f8.camel@aol.com>
Date: Sat, 04 Oct 2025 17:13:33 +0100
From: Ruben Wauters <rubenru09@....com>
To: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 	airlied@...il.com, simona@...ll.ch, mingo@...nel.org, tglx@...utronix.de, 
	jfalempe@...hat.com, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linuxfoundation.org, 	skhan@...uxfoundation.org,
 david.hunter.linux@...il.com
Subject: Re: [PATCH v2] drm/gud: Use kmalloc_array() instead of kmalloc()

On Tue, 2025-09-23 at 09:51 +0100, Mehdi Ben Hadj Khelifa wrote:
> Replace kmalloc with kmalloc array in drm/gud/gud_pipe.c since the
> calculation inside kmalloc is dynamic 'width * height' to avoid
> overflow.
> 
> Signed-off-by: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>

Acked-by: Ruben Wauters <rubenru09@....com>

> ---
> Changelog:
> 
> Changes since v1:
> - Use of width as element count and height as size of element to
> eliminate the mentionned calculation and overflow issues.
> 
>  drivers/gpu/drm/gud/gud_pipe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
> index 8d548d08f127..8898dc9393fb 100644
> --- a/drivers/gpu/drm/gud/gud_pipe.c
> +++ b/drivers/gpu/drm/gud/gud_pipe.c
> @@ -70,7 +70,7 @@ static size_t gud_xrgb8888_to_r124(u8 *dst, const struct drm_format_info *format
>  	height = drm_rect_height(rect);
>  	len = drm_format_info_min_pitch(format, 0, width) * height;
>  
> -	buf = kmalloc(width * height, GFP_KERNEL);
> +	buf = kmalloc_array(width, height, GFP_KERNEL);
>  	if (!buf)
>  		return 0;
>