[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20251005141925.35461-1-wangfushuai@baidu.com>
Date: Sun, 5 Oct 2025 22:19:25 +0800
From: Fushuai Wang <wangfushuai@...du.com>
To: <sfrench@...ba.org>, <pc@...guebit.org>, <ronniesahlberg@...il.com>,
<sprasad@...rosoft.com>, <tom@...pey.com>, <bharathsm@...rosoft.com>
CC: <linux-cifs@...r.kernel.org>, <samba-technical@...ts.samba.org>,
<linux-kernel@...r.kernel.org>, Fushuai Wang <wangfushuai@...du.com>
Subject: [PATCH v2] cifs: Fix copy_to_iter return value check
The return value of copy_to_iter() function will never be negative,
it is the number of bytes copied, or zero if nothing was copied.
Update the check to treat !length as an error, and return -1 in
that case.
Fixes: d08089f649a0 ("cifs: Change the I/O paths to use an iterator rather than a page list")
Signed-off-by: Fushuai Wang <wangfushuai@...du.com>
---
fs/smb/client/smb2ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index 058050f744c0..577ac2e11e77 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -4764,8 +4764,8 @@ handle_read_data(struct TCP_Server_Info *server, struct mid_q_entry *mid,
/* read response payload is in buf */
WARN_ONCE(buffer, "read data can be either in buf or in buffer");
length = copy_to_iter(buf + data_offset, data_len, &rdata->subreq.io_iter);
- if (length < 0)
- return length;
+ if (!length)
+ return -1;
rdata->got_bytes = data_len;
} else {
/* read response payload cannot be in both buf and pages */
--
2.36.1
Powered by blists - more mailing lists