linux-kernel - Re: [PATCH v3 09/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABN5=wEpekmKxFCr7nBcYGSt6ZH-g+bx7Y5Nmoo=tMrorz2XBg@mail.gmail.com>
Date: Sun, 5 Oct 2025 15:35:56 -0400
From: Chris Brown <crispybrown@...il.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Paul Sajna <sajattack@...tmarketos.org>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	David Heidelberg <david@...t.cz>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org, 
	Amir Dahan <system64fumo@...tonmail.com>
Subject: Re: [PATCH v3 09/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash

850mA looks correct for the flash, whereas the flashlight/torch should
be 100mA based on
https://github.com/EmanuelCN/android_kernel_lge_sdm845/blob/U/arch/arm64/boot/dts/lge/sdm845-judy/sdm845-camera/sdm845-judy-camera.dtsi
i.e. led-max-microamp = <100000>;

On Wed, 1 Oct 2025 at 05:04, Konrad Dybcio
<konrad.dybcio@....qualcomm.com> wrote:
>
> On 9/29/25 7:05 AM, Paul Sajna wrote:
> > So it can be used as a flashlight
> >
> > Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > index a8c8706f2057d36d5ef4130f11d9ad417f93d575..f309e6ebc075a691c7a522238b4a93ba9e63f3c0 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> > @@ -509,6 +509,19 @@ &pm8998_resin {
> >       status = "okay";
> >  };
> >
> > +&pmi8998_flash {
> > +     status = "okay";
> > +
> > +     led-0 {
> > +             function = LED_FUNCTION_FLASH;
> > +             color = <LED_COLOR_ID_WHITE>;
> > +             led-sources = <1>;
> > +             led-max-microamp = <850000>;
> > +             flash-max-microamp = <850000>;
>
> Allowing the same current for flash (brief on/off for night photos)
> and LED (flashlight which you normally toggle through quick settings)
> sounds no less than suspicious
>
> Konrad
>
> > +             flash-max-timeout-us = <500000>;
> > +     };
> > +};
> > +
> >  &pmi8998_lpg {
> >       status = "okay";
> >
> >