[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20251005-drm_draw_conv_check-v1-2-9c814d9362f6@valla.it>
Date: Sun, 05 Oct 2025 22:21:35 +0200
From: Francesco Valla <francesco@...la.it>
To: Jocelyn Falempe <jfalempe@...hat.com>,
Javier Martinez Canillas <javierm@...hat.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Francesco Valla <francesco@...la.it>
Subject: [PATCH 2/3] drm/log: avoid WARN when searching for usable format
Use drm_draw_can_convert_from_xrgb8888() instead of
drm_draw_color_from_xrgb8888() while searching for a usable color
format. This avoids a WARN in case the first format is not usable.
Signed-off-by: Francesco Valla <francesco@...la.it>
---
drivers/gpu/drm/clients/drm_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/clients/drm_log.c
index d239f1e3c456397ad64007b20dde716f5d3d0881..c0150f0c3b4b395e6e2126cf0d9660c967c182ec 100644
--- a/drivers/gpu/drm/clients/drm_log.c
+++ b/drivers/gpu/drm/clients/drm_log.c
@@ -182,7 +182,7 @@ static u32 drm_log_find_usable_format(struct drm_plane *plane)
int i;
for (i = 0; i < plane->format_count; i++)
- if (drm_draw_color_from_xrgb8888(0xffffff, plane->format_types[i]) != 0)
+ if (drm_draw_can_convert_from_xrgb8888(plane->format_types[i]))
return plane->format_types[i];
return DRM_FORMAT_INVALID;
}
--
2.51.0
Powered by blists - more mailing lists