linux-kernel - Re: [PATCH] mm/vmscan: Remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOLfOUgoEskd8jyE@casper.infradead.org>
Date: Sun, 5 Oct 2025 22:12:25 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Fushuai Wang <wangfushuai@...du.com>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, david@...hat.com,
	mhocko@...nel.org, zhengqi.arch@...edance.com,
	shakeel.butt@...ux.dev, lorenzo.stoakes@...cle.com,
	axelrasmussen@...gle.com, yuanchu@...gle.com, weixugc@...gle.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmscan: Remove redundant __GFP_NOWARN

On Sun, Oct 05, 2025 at 08:43:29PM +0800, Fushuai Wang wrote:
> -		.gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN |
> -			__GFP_NOMEMALLOC | GFP_NOWAIT,
> +		.gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOMEMALLOC |
> +			GFP_NOWAIT,

Please just remove the NOWARN.  There's no need to reflow the other
flags and break the 80 column limit.