linux-kernel - Re: [PATCH v3 0/3] On-chip RTC support for ExynosAutov9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510052142538d7fd672@mail.local>
Date: Sun, 5 Oct 2025 23:42:53 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Devang Tailor <dev.tailor@...sung.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	alim.akhtar@...sung.com, linux-rtc@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	henrik@...mler.se, faraz.ata@...sung.com
Subject: Re: [PATCH v3 0/3] On-chip RTC support for ExynosAutov9

On 05/09/2025 16:35:51+0530, Devang Tailor wrote:
> Enable on-chip RTC support. The on-chip RTC of this SoC is similar
> to the previous version of Samsung SoCs except for TICNT tick time
> counter. So re-use the existing RTC driver with applicable call-backs
> for initialization and IRQ handling without accessing TICNT counter.
> 
> As suggested in review comment, instead of adding separate disable()
> call-back, re-used the existing s3c24xx_rtc_disable() by adding a new
> bool 'use_s3c2410_ticnt' in rtc_data to avoid accessing TICNT counter
> which is not valid for RTC of ExynosAutov9.
> 
> Setting and getting hardware clock has been tested using 'hwclock'
> and 'date' utilities.
> 
> Alarm interrupt has been checked with incrementing interrupt
> count via "cat /proc/interrupts | grep rtc" for 10sec
> wakeup time via "echo +10 > /sys/class/rtc/rtc0/wakealarm"
> 
> changelog
> ---
> Changes in v3:
> - 1/3 : Added Tag 'Reviewed-by'
> - 2/3 : Fixed the review comment of v2 to re-use the existing disable()
> 	instead of adding new one.
>       : Not adding Tag 'Reviewed-by' from V2 since the patch has been
> 	changed
> - 3/3 : Added Tag 'Reviewed-by'
> link for v2 : https://lore.kernel.org/linux-rtc/20250710083434.1821671-1-dev.tailor@samsung.com/
> 
> 
> Changes in v2:
> - Fixed the review comment of v1 for mis-aligmnent & asymmetry bit logic.
> - link for v1 : https://lore.kernel.org/linux-rtc/20250702052426.2404256-1-dev.tailor@samsung.com/
> 
> 
> Devang Tailor (3):
>   dt-bindings: rtc: s3c-rtc: add compatible for exynosautov9
>   rtc: s3c: support for exynosautov9 on-chip RTC
>   arm64: dts: exynosautov9: add RTC DT node
> 
>  .../devicetree/bindings/rtc/s3c-rtc.yaml      |  1 +
>  .../boot/dts/exynos/exynosautov9-sadk.dts     |  4 ++++
>  arch/arm64/boot/dts/exynos/exynosautov9.dtsi  | 10 +++++++++
>  drivers/rtc/rtc-s3c.c                         | 21 ++++++++++++++++---
>  4 files changed, 33 insertions(+), 3 deletions(-)
> 
> 
> base-commit: 4ac65880ebca1b68495bd8704263b26c050ac010

You should rebase on top of rtc-next as s3c2410 support has been
removed.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com