linux-kernel - Re: [GIT PULL] TPM DEVICE DRIVER: tpmdd-next-v6.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9f441ba805ddf2c4608df8ec6a965298d4fab73.camel@HansenPartnership.com>
Date: Mon, 06 Oct 2025 19:11:25 -0400
From: James Bottomley <James.Bottomley@...senPartnership.com>
To: Jonathan McDowell <noodles@...th.li>, Jarkko Sakkinen <jarkko@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, Peter Huewe
 <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>, David Howells
 <dhowells@...hat.com>, keyrings@...r.kernel.org, 
 linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org, Jonathan
 McDowell <noodles@...a.com>
Subject: Re: [GIT PULL] TPM DEVICE DRIVER: tpmdd-next-v6.18

On Mon, 2025-10-06 at 22:40 +0100, Jonathan McDowell wrote:
> What should we do if we get O_EXCL and O_RDONLY? Return an error?
> Ignore the O_EXCL flag?

As a command/response interface, it can't be operated read only ... so
I think we should just return -EINVAL (or something more appropriate)
if someone tries to open it O_RDONLY regardless of O_EXCL.

Regards,

James