linux-kernel - Re: [PATCH 1/4] staging: rtl8723bs: clean up lines ending with '(' in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aONvOsbVxGYKZnvD@stanley.mountain>
Date: Mon, 6 Oct 2025 10:26:50 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Rohan Tripathi <trohan2000@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging: rtl8723bs: clean up lines ending with '('
 in rtw_ap.c

On Sun, Oct 05, 2025 at 11:59:16AM -0400, Rohan Tripathi wrote:
> This patch fixes coding style issues where lines ended with an opening
> parenthesis. These expressions were reformatted so that opening
> parentheses remain on the same line as the statement, with proper
> alignment of continued arguments.
> 
> This is a coding style cleanup only. No functional changes.
> 
> Signed-off-by: Rohan Tripathi <trohan2000@...il.com>
> ---

This needs to be marked as a v2:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

>  drivers/staging/rtl8723bs/core/rtw_ap.c | 250 +++++++++++-------------
>  1 file changed, 109 insertions(+), 141 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 0908f2234f67..93ab0015ca89 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -480,14 +480,13 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
>  		/* check if sta supports rx ampdu */
>  		phtpriv_sta->ampdu_enable = phtpriv_ap->ampdu_enable;
>  
> -		phtpriv_sta->rx_ampdu_min_spacing = (
> -			phtpriv_sta->ht_cap.ampdu_params_info & IEEE80211_HT_CAP_AMPDU_DENSITY
> -		) >> 2;
> +		phtpriv_sta->rx_ampdu_min_spacing =
> +		(phtpriv_sta->ht_cap.ampdu_params_info &
> +		 IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2;

No, still not nice.  I think I would go over 80 characters.

	phtpriv_sta->rx_ampdu_min_spacing = (phtpriv_sta->ht_cap.ampdu_params_info &
					     IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2;

Another option would be to do:

	phtpriv_sta->rx_ampdu_min_spacing =
			(phtpriv_sta->ht_cap.ampdu_params_info &
			 IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2;

> @@ -498,15 +497,13 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)
>  		phtpriv_sta->ch_offset = pmlmeext->cur_ch_offset;
>  
>  		/* check if sta support s Short GI 20M */
> -		if ((
> -			phtpriv_sta->ht_cap.cap_info & phtpriv_ap->ht_cap.cap_info
> -		) & cpu_to_le16(IEEE80211_HT_CAP_SGI_20))
> +		if ((phtpriv_sta->ht_cap.cap_info & phtpriv_ap->ht_cap.cap_info) &
> +		cpu_to_le16(IEEE80211_HT_CAP_SGI_20))

This needs to be done like so:

		if ((phtpriv_sta->ht_cap.cap_info & phtpriv_ap->ht_cap.cap_info) &
		    cpu_to_le16(IEEE80211_HT_CAP_SGI_20))

[tab][tab][space][space][space][space]cpu_to_le16(IEEE80211_HT_CAP_SGI_20))

You get the idea.  Same for the rest of the patchset.

regards,
dan carpenter