linux-kernel - Re: [PATCH 18/20] arm64: dts: qcom: kaanapali-mtp: Add audio support (WSA8845, WCD9395, DMIC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43ba93bd-0dba-415b-8a7e-cdc4d954f79d@kernel.org>
Date: Mon, 6 Oct 2025 17:48:10 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Prasad Kumpatla <prasad.kumpatla@....qualcomm.com>,
 Jingyi Wang <jingyi.wang@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com,
 trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com
Subject: Re: [PATCH 18/20] arm64: dts: qcom: kaanapali-mtp: Add audio support
 (WSA8845, WCD9395, DMIC)

On 30/09/2025 21:06, Prasad Kumpatla wrote:
> 
> On 9/25/2025 6:56 PM, Krzysztof Kozlowski wrote:
>> On Thu, 25 Sept 2025 at 09:18, Jingyi Wang <jingyi.wang@....qualcomm.com> wrote:
>>> From: Prasad Kumpatla <prasad.kumpatla@....qualcomm.com>
>>>
>>> Add support for audio on the Kaanapali MTP platform by introducing device
>>> tree nodes for WSA8845 smart speaker amplifier for playback, DMIC
>>> microphone for capture, and sound card routing. The WCD9395 codec is add
>>> to supply MIC-BIAS, for enabling onboard microphone capture.
>>>
>>> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@....qualcomm.com>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 226 +++++++++++++++++++++++++++++
>>>   1 file changed, 226 insertions(+)
>>>
>> Audio is not a separate feature from USB.
> 
> I didn't understand this, Could you please help me to provide more 
> context on it?
> Is this regarding Audio over Type-c?

USB depends on ADSP, so your split of patches into separate audio commit
is just incorrect.

> 
>> It's simply incomplete
>> picture which is wrong for case of submitting everything at once.
>> Either you release early, release often (which I asked you many
>> times), or you submit complete work.

And here I explained why.

> 
> These patches enable usecase for Speaker playback and On-board-Mic
> Capture. Do you consider is there is anything need to do to make it 
> complete ?

Yes, please squash patches.


Best regards,
Krzysztof