[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025100655-prankish-parking-9059@gregkh>
Date: Mon, 6 Oct 2025 11:24:16 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Maarten Lankhorst <dev@...khorst.se>
Cc: Mukesh Ojha <mukesh.ojha@....qualcomm.com>,
linux-kernel@...r.kernel.org, intel-xe@...ts.freedesktop.org,
Mukesh Ojha <quic_mojha@...cinc.com>,
Johannes Berg <johannes@...solutions.net>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Danilo Krummrich <dakr@...nel.org>, stable@...r.kernel.org,
Matthew Brost <matthew.brost@...el.com>
Subject: Re: [PATCH] devcoredump: Fix circular locking dependency with
devcd->mutex.
On Mon, Oct 06, 2025 at 11:11:01AM +0200, Maarten Lankhorst wrote:
> >> @@ -401,13 +424,20 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner,
> >>
> >> dev_set_uevent_suppress(&devcd->devcd_dev, false);
> >> kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD);
> >> - INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
> >> - schedule_delayed_work(&devcd->del_wk, timeout);
> >> +
> >> + /*
> >> + * Safe to run devcd_del() now that we are done with devcd_dev.
> >> + * Alternatively we could have taken a ref on devcd_dev before
> >> + * dropping the lock.
> >> + */
> >> + devcd->init_completed = true;
> >> mutex_unlock(&devcd->mutex);
> >> return;
> >> put_device:
> >> - put_device(&devcd->devcd_dev);
> >> mutex_unlock(&devcd->mutex);
> >> + cancel_delayed_work_sync(&devcd->del_wk);
> >> + put_device(&devcd->devcd_dev);
> >> +
> >
> > Acked-by: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
>
> Thanks, through what tree can this be merged?
I can look into doing that after -rc1 is out.
thanks,
greg k-h
Powered by blists - more mailing lists