linux-kernel - Re: CVE-2025-39751: ALSA: hda/ca0132: Fix buffer overflow in add_tuning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b12d18b040c39eb361c0f5aabf290236e3d0da66.camel@oracle.com>
Date: Mon, 6 Oct 2025 09:19:42 +0000
From: Siddh Raman Pant <siddh.raman.pant@...cle.com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "cve@...nel.org" <cve@...nel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: CVE-2025-39751: ALSA: hda/ca0132: Fix buffer overflow in
 add_tuning_control

On Mon, Oct 06 2025 at 13:44:23 +0530, gregkh@...uxfoundation.org
wrote:
> On Mon, Oct 06, 2025 at 07:07:00AM +0000, Siddh Raman Pant wrote:
> > On Thu, 11 Sep 2025 18:52:52 +0200, Greg Kroah-Hartman wrote:
> > > ALSA: hda/ca0132: Fix buffer overflow in add_tuning_control
> > > 
> > > The 'sprintf' call in 'add_tuning_control' may exceed the 44-byte
> > > buffer if either string argument is too long. This triggers a compiler
> > > warning.
> > > Replaced 'sprintf' with 'snprintf' to limit string lengths to prevent
> > > overflow.
> > > 
> > > The Linux kernel CVE team has assigned CVE-2025-39751 to this issue.
> > 
> > While the change is good for defensive reasons, there isn't actually
> > any buffer overflow as it is to "fix".
> > 
> > The largest string possible is "Wedge Angle Playback Volume", whose
> > length is less than 44.
> 
> Thanks for the info.  What was the compiler warning about then if it
> could detect just how big the string would always be as these are static
> values?

Probably a false positive.

GCC docs does say:

	-Wformat-overflow
	-Wformat-overflow=level

	    Warn about calls to formatted input/output functions such 
	    as sprintf and vsprintf that might overflow the
destination
	    buffer. When the exact number of bytes written by a format
	    directive cannot be determined at compile-time it is
	    estimated based on heuristics that depend on the level
	    argument and on optimization. While enabling optimization 
	    will in most cases improve the accuracy of the warning, it
	    may also result in false positives.


> Should this CVE be rejected?

Yes.

Thanks,
Siddh

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)