linux-kernel - Re: [PATCH 4/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Add UW cam actuator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDB553DRF89P.15C4AKUO7IQXH@fairphone.com>
Date: Mon, 06 Oct 2025 11:44:33 +0200
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: "Konrad Dybcio" <konrad.dybcio@....qualcomm.com>, "Griffin
 Kroah-Hartman" <griffin.kroah@...rphone.com>, "Mauro Carvalho Chehab"
 <mchehab@...nel.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>,
 <devicetree@...r.kernel.org>, "Daniel Scally" <djrscally@...il.com>,
 "Sakari Ailus" <sakari.ailus@...ux.intel.com>, "Bjorn Andersson"
 <andersson@...nel.org>, "Konrad Dybcio" <konradybcio@...nel.org>,
 André Apitzsch <git@...tzsch.eu>
Cc: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 4/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Add UW cam
 actuator

Hi Konrad,

On Mon Oct 6, 2025 at 11:20 AM CEST, Konrad Dybcio wrote:
> On 10/2/25 12:15 PM, Griffin Kroah-Hartman wrote:
>> Add a node for the Dongwoon DW9800K actuator, used for focus of the
>> ultra-wide camera sensor.
>> 
>> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@...rphone.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> index 2dd2c452592aa6b0ac826f19eb9cb1a8b90cee47..0e86cd5ff527925c7dba15c4e0ee5fc409fe4ce6 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> @@ -627,6 +627,15 @@ eeprom@50 {
>>  };
>>  
>>  &cci0_i2c1 {
>> +	camera_imx858_dw9800k: actuator@e {
>> +		compatible = "dongwoon,dw9800k";
>> +		reg = <0x0e>;
>> +		vdd-supply = <&vreg_afvdd_2p8>;
>> +
>> +		dongwoon,sac-mode = <1>;
>
> This property exists, but isn't documented (you need to extend the bindings)

Please see the patchset this one depends on, which adds dt-bindings and
adds prerequisite driver support:

https://lore.kernel.org/lkml/20250920-dw9719-v2-1-028cdaa156e5@apitzsch.eu/

Regards
Luca

>
>> +		dongwoon,vcm-prescale = <16>;
>
> This property is neither documented, nor consumed by the driver (it may
> or may not matter to you, check against what your presumably-BSP driver
> does with it)
>
> Konrad