linux-kernel - Re: [RFC v2 2/3] atomic: Specify alignment for atomic_t and atomic64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <92c5af4d-c6e9-43bf-ba2c-ce6627b8d962@app.fastmail.com>
Date: Mon, 06 Oct 2025 13:09:07 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Peter Zijlstra" <peterz@...radead.org>
Cc: "Finn Thain" <fthain@...ux-m68k.org>,
 "Geert Uytterhoeven" <geert@...ux-m68k.org>, "Will Deacon" <will@...nel.org>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Boqun Feng" <boqun.feng@...il.com>, "Jonathan Corbet" <corbet@....net>,
 "Mark Rutland" <mark.rutland@....com>, linux-kernel@...r.kernel.org,
 Linux-Arch <linux-arch@...r.kernel.org>, linux-m68k@...r.kernel.org,
 "Lance Yang" <lance.yang@...ux.dev>
Subject: Re: [RFC v2 2/3] atomic: Specify alignment for atomic_t and atomic64_t

On Mon, Oct 6, 2025, at 12:22, Peter Zijlstra wrote:
> On Mon, Oct 06, 2025 at 12:07:24PM +0200, Arnd Bergmann wrote:
>
>> It looks like Mark Rutland fixed the try_cmpxchg() function this
>> way in commit ec570320b09f ("locking/atomic: Correct (cmp)xchg()
>> instrumentation"), but for some reason we still have the wrong
>> annotation on the atomic_try_cmpxchg() helpers.
>
>> Mark, I've tried to modify your script to produce that output,
>> the output looks correct to me, but it makes the script more
>> complex than I liked and I'm not sure that matching on
>> "${type}"="p" is the best way to check for this.
>
> I don't see anything wrong with this. The result looks good.

Thanks for having a look, I've sent it out as a proper patch now.

      Arnd