linux-kernel - Re: [GIT PULL] TPM DEVICE DRIVER: tpmdd-next-v6.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOOu1f1QWQNtkl6c@kernel.org>
Date: Mon, 6 Oct 2025 14:58:13 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
	David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org,
	linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] TPM DEVICE DRIVER: tpmdd-next-v6.18

On Sun, Oct 05, 2025 at 11:09:08AM -0700, Linus Torvalds wrote:
> On Sun, 5 Oct 2025 at 08:47, Jarkko Sakkinen <jarkko@...nel.org> wrote:
> >
> >      This pull request disables
> > TCG_TPM2_HMAC from the default configuration as it does not perform well
> > enough [1].
> >
> > [1] https://lore.kernel.org/linux-integrity/20250825203223.629515-1-jarkko@kernel.org/
> 
> This link is entirely useless, and doesn't explain what the problem
> was and *why* TPM2_TCG_HMAC shouldn't be on by default.
> 
> I think a much better link is
> 
>    https://lore.kernel.org/linux-integrity/20250814162252.3504279-1-cfenn@google.com/
> 
> which talks about the problems that TPM2_TCG_HMAC causes.
> 
> Which weren't just about "not performing well enough", but actually
> about how it breaks TPM entirely for some cases.

Fair enough. I'll also enumerate the issues, and also roadmap
to heal the feature.

> 
>               Linus

BR, Jarkko