linux-kernel - Re: [PATCH v1 3/9] parisc: Convert DMA map_page to map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <d8c1e548-ebc5-4a07-8bf5-d98e9f2e6587@app.fastmail.com>
Date: Mon, 06 Oct 2025 07:03:49 +0300
From: "Leon Romanovsky" <leon@...nel.org>
To: "Jason Gunthorpe" <jgg@...dia.com>
Cc: "Marek Szyprowski" <m.szyprowski@...sung.com>,
 "Andreas Larsson" <andreas@...sler.com>,
 "Borislav Petkov" <bp@...en8.de>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>,
 "David Miller" <davem@...emloft.net>,
 "Geoff Levand" <geoff@...radead.org>, "Helge Deller" <deller@....de>,
 "Ingo Molnar" <mingo@...hat.com>, iommu@...ts.linux.dev,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Jason Wang" <jasowang@...hat.com>, "Juergen Gross" <jgross@...e.com>,
 linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org,
 "Madhavan Srinivasan" <maddy@...ux.ibm.com>,
 "Matt Turner" <mattst88@...il.com>,
 "Michael Ellerman" <mpe@...erman.id.au>,
 "Michael S. Tsirkin" <mst@...hat.com>,
 "Richard Henderson" <richard.henderson@...aro.org>,
 sparclinux@...r.kernel.org,
 "Stefano Stabellini" <sstabellini@...nel.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Thomas Gleixner" <tglx@...utronix.de>, virtualization@...ts.linux.dev,
 x86@...nel.org, xen-devel@...ts.xenproject.org,
 "Magnus Lindholm" <linmag7@...il.com>
Subject: Re: [PATCH v1 3/9] parisc: Convert DMA map_page to map_phys interface

On Mon, Oct 6, 2025, at 02:31, Jason Gunthorpe wrote:
> On Sun, Oct 05, 2025 at 04:22:59PM +0300, Leon Romanovsky wrote:
>> @@ -582,7 +582,7 @@ ccio_io_pdir_entry(__le64 *pdir_ptr, space_t sid, unsigned long vba,
>>         ** Grab virtual index [0:11]
>>         ** Deposit virt_idx bits into I/O PDIR word
>>         */
>> -       asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (vba));
>> +       asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (pba));
>
> Don't know how I missed this, but this is the virtual address for the
> cache invalidate James mentioned
>
> So the optimal is to drop the lpa() and to use phys_to_virt() to get
> vba for this instruction.

The optimal is to keep parisc arch code as I did in v1 and don't change it too much.

>
> Jason