linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a5eecdd-d80f-4955-8ab7-cf6fd991a3b7@oss.qualcomm.com>
Date: Mon, 6 Oct 2025 16:49:08 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: foss@...lselvaraj.com, Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen
 properties

On 9/19/25 11:02 AM, Joel Selvaraj via B4 Relay wrote:
> From: Joel Selvaraj <foss@...lselvaraj.com>
> 
> The touchscreen properties previously upstreamed was based on downstream
> touchscreen driver. We ended up adapting upstream edt_ft5x06 driver to
> support the FocalTech FT5452 touchscreen controller used in this device.
> Update the touchscreen properties to match with the upstream edt_ft5x06
> driver. Also, as mentioned, the touchscreen controller used in this
> device is ft5452 and not fts8719. Fix it.

This is a little difficult to read, breaking the paragraph somewhere
would help.

> 
> Signed-off-by: Joel Selvaraj <foss@...lselvaraj.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 89260fce6513937224f76a94e1833a5a8d59faa4..d4062844234e33b0d501bcb7d0b6d5386c822937 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -434,20 +434,19 @@ &i2c5 {
>  	status = "okay";
>  
>  	touchscreen@38 {
> -		compatible = "focaltech,fts8719";
> +		compatible = "focaltech,ft5452";
>  		reg = <0x38>;
> -		wakeup-source;

All the changes look good given your commit message, but you dropped
this wakeup-source property without explanation. It's fine to do so
if it's intended, but please mention it if so

Konrad