[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1983025922.01759726502090.JavaMail.epsvc@epcpadp1new>
Date: Mon, 29 Sep 2025 18:58:05 +0530
From: Neeraj Kumar <s.neeraj@...sung.com>
To: Dave Jiang <dave.jiang@...el.com>
Cc: linux-cxl@...r.kernel.org, nvdimm@...ts.linux.dev,
linux-kernel@...r.kernel.org, gost.dev@...sung.com,
a.manzanares@...sung.com, vishak.g@...sung.com, neeraj.kernel@...il.com,
cpgs@...sung.com
Subject: Re: [PATCH V3 05/20] nvdimm/namespace_label: Add namespace label
changes as per CXL LSA v2.1
On 23/09/25 02:48PM, Dave Jiang wrote:
>> +static inline void nsl_set_type(struct nvdimm_drvdata *ndd,
>> + struct nd_namespace_label *ns_label)
>> +{
>> + if (ndd->cxl && ns_label)
>> + uuid_parse(CXL_NAMESPACE_UUID, (uuid_t *) ns_label->cxl.type);
>
>You can do:
>uuid_copy(ns_label->cxl.type, cxl_namespace_uuid);
>
>All the constant UUIDs are preparsed by nd_label_init(). For the entire series you can use those pre-parsed uuid_t and just use uuid_copy() instead of having to do string to uuid_t conversions.
>
>DJ
>
Yes using preparsed UUID's will help to avoid extra uuid_parse() usage.
Sure, I will fix it accordingly
Regards,
Neeraj
Powered by blists - more mailing lists