linux-kernel - Re: [PATCH][next] btrfs: Avoid -Wflex-array-member-not-at-end warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251006160601.GA4412@twin.jikos.cz>
Date: Mon, 6 Oct 2025 18:06:01 +0200
From: David Sterba <dsterba@...e.cz>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: dsterba@...e.cz, "Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] btrfs: Avoid -Wflex-array-member-not-at-end warning

On Fri, Oct 03, 2025 at 04:21:17PM +0100, Gustavo A. R. Silva wrote:
> On 10/3/25 16:15, David Sterba wrote:
> > On Fri, Oct 03, 2025 at 03:51:24PM +0100, Gustavo A. R. Silva wrote:
> >>>>
> >>>> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> >>>> index 9230e5066fc6..2b7cf49a35bb 100644
> >>>> --- a/fs/btrfs/send.c
> >>>> +++ b/fs/btrfs/send.c
> >>>> @@ -178,7 +178,6 @@ struct send_ctx {
> >>>>    	u64 cur_inode_rdev;
> >>>>    	u64 cur_inode_last_extent;
> >>>>    	u64 cur_inode_next_write_offset;
> >>>> -	struct fs_path cur_inode_path;
> >>>>    	bool cur_inode_new;
> >>>>    	bool cur_inode_new_gen;
> >>>>    	bool cur_inode_deleted;
> >>>> @@ -305,6 +304,9 @@ struct send_ctx {
> >>>>    
> >>>>    	struct btrfs_lru_cache dir_created_cache;
> >>>>    	struct btrfs_lru_cache dir_utimes_cache;
> >>>> +
> >>>> +	/* Must be last --ends in a flexible-array member. */
> >>>                           ^^
> >>>
> >>> Is this an en dash?
> >>
> >> Not sure what you mean.
> > 
> > En dash is a punctuation mark not typically used in comments, nowadays
> > found in AI generated code/text. I was just curious.
> 
> Ah yes, I've been using this punctuation mark for this sorts of comments,

It's quite odd to see it formatted like that, it's confusing and looks
like a typo. The emdash "---" looks like the right punct. mark as it
separates extra information, if we'd want to delve into typographical
conventions.