linux-kernel - Re: [PATCH 04/18] reset: rzv2h-usb2phy: Set VBENCTL register for OTG mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <593eb851ae6ce0ec03ddeacf436180b6538fdd1e.camel@pengutronix.de>
Date: Mon, 06 Oct 2025 18:31:39 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>, 
	tomm.merciai@...il.com
Cc: linux-renesas-soc@...r.kernel.org, biju.das.jz@...renesas.com, Yoshihiro
 Shimoda <yoshihiro.shimoda.uh@...esas.com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I	 <kishon@...nel.org>, Geert Uytterhoeven
 <geert+renesas@...der.be>, Magnus Damm	 <magnus.damm@...il.com>, Fabrizio
 Castro <fabrizio.castro.jz@...esas.com>,  Lad Prabhakar
 <prabhakar.mahadev-lad.rj@...renesas.com>, linux-phy@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/18] reset: rzv2h-usb2phy: Set VBENCTL register for
 OTG mode

On Mi, 2025-10-01 at 23:26 +0200, Tommaso Merciai wrote:
> Add logic to set the VBENCTL register when the USB controller operates in
> OTG mode. This is required to ensure proper USB transceiver behavior when
> the device is configured as OTG.
> 
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>

I had reservations about this driver before, because of the opaque
register initialization sequence, and I was told that no, this is a
reset driver alright [1].

Can you please try to find a proper abstraction for this, because
drivers/reset is not the correct place for USB OTG mode handling.

[1] https://lore.kernel.org/all/TYCPR01MB12093DB963348A8FD58409E5AC2DE2@TYCPR01MB12093.jpnprd01.prod.outlook.com/


regards
Philipp