[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20251006-gs101-pd-v1-9-f0cb0c01ea7b@linaro.org>
Date: Mon, 06 Oct 2025 17:43:35 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>, Rob Herring <robh@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Ulf Hansson <ulf.hansson@...aro.org>
Cc: Peter Griffin <peter.griffin@...aro.org>,
Tudor Ambarus <tudor.ambarus@...aro.org>,
Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org,
André Draszik <andre.draszik@...aro.org>
Subject: [PATCH 09/10] pmdomain: samsung: use dev_err() instead of pr_err()
dev_err() gives us more consistent error messages, which include the
device. Switch to using dev_err().
Signed-off-by: André Draszik <andre.draszik@...aro.org>
---
drivers/pmdomain/samsung/exynos-pm-domains.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomain/samsung/exynos-pm-domains.c
index c1b5830b2ad3e8b272dcc8ebc364be49aa7fda7c..06e1b0eaca18205a549c8e8136ee15279eb3089d 100644
--- a/drivers/pmdomain/samsung/exynos-pm-domains.c
+++ b/drivers/pmdomain/samsung/exynos-pm-domains.c
@@ -29,6 +29,7 @@ struct exynos_pm_domain_config {
*/
struct exynos_pm_domain {
struct regmap *regmap;
+ struct device *dev;
struct generic_pm_domain pd;
u32 local_pwr_cfg;
u32 configuration_reg;
@@ -53,8 +54,9 @@ static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on)
(val & pd->local_pwr_cfg) == pwr,
100, 1 * USEC_PER_MSEC);
if (err)
- pr_err("Power domain %s %sable failed: %d (%#.2x)\n",
- domain->name, power_on ? "en" : "dis", err, val);
+ dev_err(pd->dev,
+ "Power domain %s %sable failed: %d (%#.2x)\n",
+ domain->name, power_on ? "en" : "dis", err, val);
return err;
}
@@ -116,6 +118,8 @@ static int exynos_pd_probe(struct platform_device *pdev)
if (!pd)
return -ENOMEM;
+ pd->dev = dev;
+
pd->pd.name = exynos_get_domain_name(dev, np);
if (!pd->pd.name)
return -ENOMEM;
--
2.51.0.618.g983fd99d29-goog
Powered by blists - more mailing lists