linux-kernel - Re: [PATCH v2] kbuild: uapi: Strip comments before size type check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251006180201.GA429708@ax162>
Date: Mon, 6 Oct 2025 11:02:01 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Andreas Schwab <schwab@...ux-m68k.org>,
	Nicolas Schier <nicolas.schier@...ux.dev>,
	Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
	linux-kbuild@...r.kernel.org, linux-m68k@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: uapi: Strip comments before size type check

Hi Geert,

On Mon, Oct 06, 2025 at 03:20:52PM +0200, Geert Uytterhoeven wrote:
> On Mon, 6 Oct 2025 at 14:40, Andreas Schwab <schwab@...ux-m68k.org> wrote:
> > On Okt 06 2025, Geert Uytterhoeven wrote:
> > > --- a/usr/include/headers_check.pl
> > > +++ b/usr/include/headers_check.pl
> > > @@ -155,6 +155,8 @@ sub check_sizetypes
> > >       if (my $included = ($line =~ /^\s*#\s*include\s+[<"](\S+)[>"]/)[0]) {
> > >               check_include_typesh($included);
> > >       }
> > > +     # strip comments (single-line only)
> > > +     $line =~ s@\/\*.*?\*\/@@;
> >
> > I don't think you need to quote the forward slashes in the regexp.
> 
> Thanks, you are right!
> 
> So far for not just following my instinct, but looking for similar functionality
> in other scripts like scripts/kernel-doc.pl...

I will fix this up when applying. I think I am going to adjust the
comment to

  # strip single-line comments, as types may be referenced within them

just to be a little more verbose about why it is being done.

Sorry for the breakage!

Cheers,
Nathan