[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251006111211.28f018bc@kernel.org>
Date: Mon, 6 Oct 2025 11:12:11 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: I Viswanath <viswanathiyyappan@...il.com>
Cc: Thangaraj.S@...rochip.com, Rengarajan.S@...rochip.com,
UNGLinuxDriver@...rochip.com, andrew+netdev@...n.ch, davem@...emloft.net,
edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev,
david.hunter.linux@...il.com
Subject: Re: [PATCH net] net: usb: lan78xx: fix use of improperly
initialized dev->chipid in lan78xx_reset
On Wed, 1 Oct 2025 18:44:09 +0530 I Viswanath wrote:
> dev->chipid is used in lan78xx_init_mac_address before it's initialized:
>
> lan78xx_reset() {
> lan78xx_init_mac_address()
> lan78xx_read_eeprom()
> lan78xx_read_raw_eeprom() <- dev->chipid is used here
>
> dev->chipid = ... <- dev->chipid is initialized correctly here
> }
>
> Reorder initialization so that dev->chipid is set before calling
> lan78xx_init_mac_address().
We need a Fixes tag
--
pw-bot: cr
Powered by blists - more mailing lists