linux-kernel - Re: [PATCH v3] ice: ice_adapter: release xa entry on adapter allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175977541325.1511446.4780577963402519047.git-patchwork-notify@kernel.org>
Date: Mon, 06 Oct 2025 18:30:13 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: jacob.e.keller@...el.com, anthony.l.nguyen@...el.com,
 przemyslaw.kitszel@...el.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ice: ice_adapter: release xa entry on adapter
 allocation
 failure

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed,  1 Oct 2025 19:53:36 +0800 you wrote:
> When ice_adapter_new() fails, the reserved XArray entry created by
> xa_insert() is not released. This causes subsequent insertions at
> the same index to return -EBUSY, potentially leading to
> NULL pointer dereferences.
> 
> Reorder the operations as suggested by Przemek Kitszel:
> 1. Check if adapter already exists (xa_load)
> 2. Reserve the XArray slot (xa_reserve)
> 3. Allocate the adapter (ice_adapter_new)
> 4. Store the adapter (xa_store)
> 
> [...]

Here is the summary with links:
  - [v3] ice: ice_adapter: release xa entry on adapter allocation failure
    https://git.kernel.org/netdev/net/c/2db687f3469d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html