linux-kernel - Re: [PATCH] net: phy: microchip_t1: LAN887X: Fix device init issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f74c41e-15cd-40f3-8fb2-fa636f169d70@lunn.ch>
Date: Mon, 6 Oct 2025 20:44:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Divya.Koppera@...rochip.com
Cc: josef@...chen.org, Arun.Ramadoss@...rochip.com,
	UNGLinuxDriver@...rochip.com, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: microchip_t1: LAN887X: Fix device init issues.

> phy_sanitize_settings() is supposed to pick the least supported
> speed from the supported list when speed is not initialized.

What makes you think it should pick the slowest speed? The kdoc for
the function is:

/**
 * phy_sanitize_settings - make sure the PHY is set to supported speed and duplex
 * @phydev: the target phy_device struct
 *
 * Description: Make sure the PHY is set to supported speeds and
 *   duplexes.  Drop down by one in this order:  1000/FULL,
 *   1000/HALF, 100/FULL, 100/HALF, 10/FULL, 10/HALF.

So it should pick 1000Full if available. If not it will try 1000Half,
if not 100Full etc.

And the comment is actually a bit out of date. It will actually start
from 800G Full, 400G Full, 200G Full, 100G Full, not that anybody does
Copper at these speeds.

	Andrew