[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aOQRpvRrXJDONnh1@slm.duckdns.org>
Date: Mon, 6 Oct 2025 08:59:50 -1000
From: Tejun Heo <tj@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Steven Rostedt <rostedt@...dmis.org>,
LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...nel.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Waiman Long <longman@...hat.com>,
Johannes Weiner <hannes@...xchg.org>,
Michal Koutný <mkoutny@...e.com>,
Andrea Righi <righi.andrea@...il.com>,
Julia Lawall <Julia.Lawall@...ia.fr>,
"Luis Claudio R. Goncalves" <lgoncalv@...hat.com>,
Joseph Salisbury <joseph.salisbury@...cle.com>
Subject: Re: [PATCH] sched: cgroup: Move task_can_attach() to cpuset.c
On Mon, Oct 06, 2025 at 08:31:59PM +0200, Peter Zijlstra wrote:
> On Fri, Oct 03, 2025 at 11:38:09AM -1000, Tejun Heo wrote:
> > On Fri, Oct 03, 2025 at 12:14:21PM -0400, Steven Rostedt wrote:
> > > From: Steven Rostedt <rostedt@...dmis.org>
> > >
> > > At our monthly stable meeting, we were talking about documenting non
> > > static functions and randomly picked a function to look at. That was
> > > task_can_attach(). It was then noticed that it's only used by
> > > cgroup/cpuset.c and nothing else. It's a simple function that doesn't
> > > reference anything unique to sched/core.c, hence there's no reason that
> > > function should be there.
> > >
> > > Move it to cgroup/cpuset.c as that's the only place it is used. Also make
> > > it a static inline as it is so small.
> > >
> > > Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> >
> > Peter, if it looks good to you, I can route it through cgroup tree.
>
> Yeah, I suppose so. But there were suggested changes to the Changelog
> and actual patch so perhaps wait for v2?
Yeah, will wait for v2 and then apply it.
Thanks.
--
tejun
Powered by blists - more mailing lists