linux-kernel - Re: [PATCH] net/mlx5: fix pre-2.40 binutils assembler error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251006190851.GB2406882@ax162>
Date: Mon, 6 Oct 2025 12:08:51 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	Tariq Toukan <tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Patrisious Haddad <phaddad@...dia.com>,
	Moshe Shemesh <moshe@...dia.com>,
	Michael Guralnik <michaelgur@...dia.com>,
	Arnd Bergmann <arnd@...db.de>,
	Naresh Kamboju <naresh.kamboju@...aro.org>,
	Simon Horman <horms@...nel.org>, Cosmin Ratiu <cratiu@...dia.com>,
	Yishai Hadas <yishaih@...dia.com>, Maor Gottlieb <maorg@...dia.com>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5: fix pre-2.40 binutils assembler error

On Mon, Oct 06, 2025 at 01:56:34PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Old binutils versions require a slightly stricter syntax for the .arch_extension
> directive and fail with the extra semicolon:
> 
> /tmp/cclfMnj9.s:656: Error: unknown architectural extension `simd;'
> 
> Drop the semicolon to make it work with all supported toolchain version.
> 
> Link: https://lore.kernel.org/all/20251001163655.GA370262@ax162/
> Reported-by: Paolo Abeni <pabeni@...hat.com>
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Suggested-by: Nathan Chancellor <nathan@...nel.org>
> Fixes: fd8c8216648c ("net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/wc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wc.c b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> index c281153bd411..05e5fd777d4f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/wc.c
> @@ -266,7 +266,7 @@ static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
>  	if (cpu_has_neon()) {
>  		kernel_neon_begin();
>  		asm volatile
> -		(".arch_extension simd;\n\t"
> +		(".arch_extension simd\n\t"
>  		"ld1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%0]\n\t"
>  		"st1 {v0.16b, v1.16b, v2.16b, v3.16b}, [%1]"
>  		:
> -- 
> 2.39.5
>