[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6b91d49a-37ee-4847-81af-a1e5b0b0d4f4@oss.qualcomm.com>
Date: Mon, 6 Oct 2025 14:14:49 -0600
From: Jeff Hugo <jeff.hugo@....qualcomm.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
Carl Vanderlip <carl.vanderlip@....qualcomm.com>,
Oded Gabbay <ogabbay@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] accel/qaic: Replace kcalloc + copy_from_user with
memdup_array_user
On 9/17/2025 6:48 AM, Thorsten Blum wrote:
> Replace kcalloc() followed by copy_from_user() with memdup_array_user()
> to improve and simplify both __qaic_execute_bo_ioctl() and
> qaic_perf_stats_bo_ioctl().
>
> In __qaic_execute_bo_ioctl(), return early if an error occurs and remove
> the obsolete 'free_exec' label.
>
> Since memdup_array_user() already checks for multiplication overflow,
> remove the manual check in __qaic_execute_bo_ioctl(). Remove any unused
> local variables accordingly.
>
> Since 'ret = copy_from_user()' has been removed, initialize 'ret = 0' to
> preserve the same return value on success.
>
> No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
Applied to drm-misc-next.
-Jeff
Powered by blists - more mailing lists