linux-kernel - Re: [PATCH v3 2/2] ASoC: tas2781: Update ti,tas2781.yaml for adding tas5815 and tas5828

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251006212351.GA602416-robh@kernel.org>
Date: Mon, 6 Oct 2025 16:23:51 -0500
From: Rob Herring <robh@...nel.org>
To: Baojun Xu <baojun.xu@...com>
Cc: broonie@...nel.org, tiwai@...e.de, andriy.shevchenko@...ux.intel.com,
	13916275206@....com, alsa-devel@...a-project.org,
	shenghao-ding@...com, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, lgirdwood@...il.com,
	krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
	k-yi@...com, henry.lo@...com, robinchen@...com, jesse-ji@...com,
	will-wang@...com, jim.shil@...rtek.com, toastcheng@...gle.com,
	chinkaiting@...gle.com
Subject: Re: [PATCH v3 2/2] ASoC: tas2781: Update ti,tas2781.yaml for adding
 tas5815 and tas5828

On Sun, Sep 28, 2025 at 05:15:14PM +0800, Baojun Xu wrote:
> Update ti,tas2781.yaml for adding TAS5815/TAS5828.

That is clear from the diff. Say something about how these chips compare 
to the existing ones.

> 
> Signed-off-by: Baojun Xu <baojun.xu@...com>
> 
> ---
> v3:
>  - Rewrite the patch title

'git log --oneline' on the file or subsystem is a hint of what the 
subject should look like. In this case, something like:

ASoC: dt-bindings: ti,tas2781: Add TAS5815 and TAS5828

>  - Add TAS5815 support in yaml file
> v2:
>  - Update description for TAS5828
>  - Change commit tree to .../tiwai/sound.git
> ---
>  .../devicetree/bindings/sound/ti,tas2781.yaml | 27 ++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> index bd00afa47..192d8c560 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -24,7 +24,7 @@ description: |
>    Instruments Smart Amp speaker protection algorithm. The
>    integrated speaker voltage and current sense provides for real time
>    monitoring of loudspeaker behavior.
> -  The TAS5825/TAS5827 is a stereo, digital input Class-D audio
> +  The TAS5825/TAS5827/TAS5828 is a stereo, digital input Class-D audio
>    amplifier optimized for efficiently driving high peak power into
>    small loudspeakers. An integrated on-chip DSP supports Texas
>    Instruments Smart Amp speaker protection algorithm.
> @@ -35,8 +35,10 @@ description: |
>      https://www.ti.com/lit/gpn/tas2563
>      https://www.ti.com/lit/gpn/tas2572
>      https://www.ti.com/lit/gpn/tas2781
> +    https://www.ti.com/lit/gpn/tas5815
>      https://www.ti.com/lit/gpn/tas5825m
>      https://www.ti.com/lit/gpn/tas5827
> +    https://www.ti.com/lit/gpn/tas5828m
>  
>  properties:
>    compatible:
> @@ -65,11 +67,17 @@ properties:
>        Protection and Audio Processing, 16/20/24/32bit stereo I2S or
>        multichannel TDM.
>  
> +      ti,tas5815: 30-W, Digital Input, Stereo, Closed-loop Class-D Audio
> +      Amplifier with 96 kHz Enhanced Processing
> +
>        ti,tas5825: 38-W Stereo, Inductor-Less, Digital Input, Closed-Loop 4.5V
>        to 26.4V Class-D Audio Amplifier with 192-kHz Extended Audio Processing.
>  
>        ti,tas5827: 47-W Stereo, Digital Input, High Efficiency Closed-Loop Class-D
>        Amplifier with Class-H Algorithm
> +
> +      ti,tas5828: 50-W Stereo, Digital Input, High Efficiency Closed-Loop Class-D
> +      Amplifier with Hybrid-Pro Algorithm
>      oneOf:
>        - items:
>            - enum:
> @@ -80,8 +88,10 @@ properties:
>                - ti,tas2563
>                - ti,tas2570
>                - ti,tas2572
> +              - ti,tas5815
>                - ti,tas5825
>                - ti,tas5827
> +              - ti,tas5828
>            - const: ti,tas2781
>        - enum:
>            - ti,tas2781
> @@ -177,12 +187,27 @@ allOf:
>              minimum: 0x38
>              maximum: 0x3f
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - ti,tas5815
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 4
> +          items:
> +            minimum: 0x54
> +            maximum: 0x57
> +
>    - if:
>        properties:
>          compatible:
>            contains:
>              enum:
>                - ti,tas5827
> +              - ti,tas5828
>      then:
>        properties:
>          reg:
> -- 
> 2.25.1
>