linux-kernel - Re: [PATCH v11 05/31] x86,fs/resctrl: Refactor domain create/remove using struct rdt_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6445cb8a-73c6-46be-ac63-3ab185e6dfee@intel.com>
Date: Mon, 6 Oct 2025 14:32:35 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: "Luck, Tony" <tony.luck@...el.com>
CC: Fenghua Yu <fenghuay@...dia.com>, Maciej Wieczor-Retman
	<maciej.wieczor-retman@...el.com>, Peter Newman <peternewman@...gle.com>,
	James Morse <james.morse@....com>, Babu Moger <babu.moger@....com>, "Drew
 Fustini" <dfustini@...libre.com>, Dave Martin <Dave.Martin@....com>, Chen Yu
	<yu.c.chen@...el.com>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v11 05/31] x86,fs/resctrl: Refactor domain create/remove
 using struct rdt_domain_hdr

Hi Tony,

On 10/3/25 3:55 PM, Luck, Tony wrote:
> On Fri, Oct 03, 2025 at 08:33:00AM -0700, Reinette Chatre wrote:
>> Hi Tony,
>>
>> On 9/25/25 1:02 PM, Tony Luck wrote:
>>> Up until now, all monitoring events were associated with the L3 resource
>>> and it made sense to use the L3 specific "struct rdt_mon_domain *"
>>> arguments to functions manipulating domains.
>>>
>>> To simplify enabling of enumeration of domains for events in other
>>
>> What does "enabling of enumeration of domains" mean?
> 
> Is this better?
> 
>     To prepare for events in resources other than L3, change the calling convention
>     to pass the generic struct rdt_domain_hdr and use that to find the domain specific
>     structure where needed.

I interpret above as a solution that is unrelated to the problem because the problem
is stated as "prepare for events in *resources*" while the solution changes how
*domain* structures are accessed. 

Here is an attempt to make the problem and solution clear, please feel free to change:

	Up until now, all monitoring events were associated with the L3 resource
	and it made sense to use the L3 specific "struct rdt_mon_domain *"
	argument to functions operating on domains.

	Telemetry events will be tied to a new resource with its instances
	represented by a new domain structure that, just like struct rdt_mon_domain,
	starts with the generic	struct rdt_domain_hdr.

 	Prepare to support domains belonging to different resources by
	changing the calling convention of functions operating on domains.
	Pass the generic header and use that to find the domain specific
	structure where needed.


sidenote: I changed "manipulating" to "operating on" even though Boris wrote it since a
few of the functions changed in this patch do not manipulate the domains but instead use
them as reference.

Reinette