linux-kernel - Re: [PATCH v11 31/31] fs/resctrl: Some kerneldoc updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf071a10-0f21-45b8-929f-60e864f57a41@intel.com>
Date: Mon, 6 Oct 2025 14:34:01 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: "Luck, Tony" <tony.luck@...el.com>
CC: Fenghua Yu <fenghuay@...dia.com>, Maciej Wieczor-Retman
	<maciej.wieczor-retman@...el.com>, Peter Newman <peternewman@...gle.com>,
	James Morse <james.morse@....com>, Babu Moger <babu.moger@....com>, "Drew
 Fustini" <dfustini@...libre.com>, Dave Martin <Dave.Martin@....com>, Chen Yu
	<yu.c.chen@...el.com>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v11 31/31] fs/resctrl: Some kerneldoc updates

Hi Tony,

On 10/6/25 9:54 AM, Luck, Tony wrote:
> On Fri, Oct 03, 2025 at 05:26:45PM -0700, Reinette Chatre wrote:
>> Hi Tony,
>>
>> On 9/25/25 1:03 PM, Tony Luck wrote:
>>> resctrl event monitoring on Sub-NUMA Cluster (SNC) systems sums the
>>> counts for events across all nodes sharing an L3 cache.
>>>
>>> Update the kerneldoc for rmid_read::sum and the do_sum argument to
>>> mon_get_kn_priv() to say these are only used on the RDT_RESOURCE_L3
>>> resource.
>>
>> This is clear from the patch. Why is this needed as part of
>> telemetry event enabling? Perhaps this can be combined with the
>> unrelated SNC warnings found in "x86/resctrl: Handle domain creation/deletion
>> for RDT_RESOURCE_PERF_PKG" to be a patch dedicated to addressing SNC
>> topics related to telemetry events? 
> 
> I will add an SNC cleanup patch to the series and make these changes there.

Thank you very much.

>>
>>>
>>> Add Return: value description for l3_mon_domain_mbm_alloc(),
>>> resctrl_l3_mon_resource_init(), and domain_setup_l3_mon_state()
>>
>> Appreciate the cleanups but please have series start with cleanups instead of end.
> 
> Can I bundle these cleanups with patch 8 that renames these functions?

Good question. It is ok with me. I am not aware of concerns with doing something like
this.

Reinette