linux-kernel - Re: [PATCH 13/16] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd5f934f222116a29ef5ec19a52a9b3ae7433de9.camel@ndufresne.ca>
Date: Tue, 07 Oct 2025 14:12:48 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Krzysztof Kozlowski <krzk@...nel.org>, Sven Püschel	
 <s.pueschel@...gutronix.de>, Jacob Chen <jacob-chen@...wrt.com>, Ezequiel
 Garcia <ezequiel@...guardiasur.com.ar>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,  Conor Dooley
 <conor+dt@...nel.org>
Cc: linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 13/16] media: dt-bindings: media: rockchip-rga: add
 rockchip,rk3588-rga3

Hi,

Le mardi 07 octobre 2025 à 17:38 +0900, Krzysztof Kozlowski a écrit :
> On 07/10/2025 17:32, Sven Püschel wrote:
> > Add a new compatible for the rk3588 Rockchip SoC, which features an
> > RGA3, which is described in the TRM Part2.

Please write something here. You can't explain why RK did this, but at least
explain what are the differences and additional feature. It should also be super
clear through your patchset everything you didn't support, since when reading
your set, it really have nothing extra implemented.

> > 
> > Signed-off-by: Sven Püschel <s.pueschel@...gutronix.de>
> > ---
> >  Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > index
> > ac17cda65191be047fc61d0c806f806c6af07c7b..11e86333c56aab55d9358dc88e45e7c1eb
> > faae9e 100644
> > --- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > +++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
> > @@ -20,6 +20,7 @@ properties:
> >      oneOf:
> >        - const: rockchip,rk3288-rga
> >        - const: rockchip,rk3399-rga
> > +      - const: rockchip,rk3588-rga3
> 
> There is already rk3588-rga, so please explain in commit msg
> differences, including compatibility or lack thereof. I am confused why
> there are two completely different 2D accelerators simultaneously on
> that SoC.

It is quite strange hardware design, but this is really how the hardware is. I
personally don't expect an explanation from a third party. Its a mirror of the
VOP2 planes really.

Nicolas

> 
> Best regards,
> Krzysztof

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)