linux-kernel - Re: [PATCH 16/16] media: rockchip: rga: add rga3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46a1915e81b027d1c344eed0477683dd3a68d810.camel@ndufresne.ca>
Date: Tue, 07 Oct 2025 14:54:24 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Krzysztof Kozlowski <krzk@...nel.org>, Sven Püschel	
 <s.pueschel@...gutronix.de>, Jacob Chen <jacob-chen@...wrt.com>, Ezequiel
 Garcia <ezequiel@...guardiasur.com.ar>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,  Conor Dooley
 <conor+dt@...nel.org>
Cc: linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 16/16] media: rockchip: rga: add rga3 support

Hi Krzysztof,

Le mardi 07 octobre 2025 à 17:39 +0900, Krzysztof Kozlowski a écrit :
> On 07/10/2025 17:32, Sven Püschel wrote:
> > Add support for the RGA3 unit contained in the RK3588.
> > 
> > Only a basic feature set consisting of scaling and color conversion is
> > implemented. Advanced features like rotation and cropping will just be
> > ignored. Also the BT601F color space conversion is currently hard coded.
> > 
> > The register address defines were copied from the
> > vendor Rockchip kernel sources and slightly adjusted to not start at 0
> > again for the cmd registers.
> > 
> > Signed-off-by: Sven Püschel <s.pueschel@...gutronix.de>
> > ---
> >  drivers/media/platform/rockchip/rga/Makefile  |   2 +-
> >  drivers/media/platform/rockchip/rga/rga.c     |   4 +
> >  drivers/media/platform/rockchip/rga/rga.h     |   2 +-
> >  drivers/media/platform/rockchip/rga/rga3-hw.c | 490
> > ++++++++++++++++++++++++++
> >  drivers/media/platform/rockchip/rga/rga3-hw.h | 186 ++++++++++
> >  5 files changed, 682 insertions(+), 2 deletions(-)
> 
> Your order of patches is a mess. DTS cannot be in the middle. In fact,
> DTS should not be even in this patchset, because you are targeting media.

Indeed, order is broken, though I do appreciate having the DTS as part of the
submission, this way I don't have to chase for them when testing. That being
said, a link or message ID in the cover later would be as good.

Nicolas

> 
> Best regards,
> Krzysztof

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)