linux-kernel - Re: [git pull] drm for 6.18-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nwosJkFp8PyqY=XLt6ZMS2rnsTHaN-arzQUemR5cuqRg@mail.gmail.com>
Date: Tue, 7 Oct 2025 21:24:47 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Maarten ter Huurne <maarten@...ewalker.org>, John Hubbard <jhubbard@...dia.com>, 
	Dave Airlie <airlied@...il.com>, Miguel Ojeda <ojeda@...nel.org>, Sima Vetter <sima@...ll.ch>, 
	dri-devel <dri-devel@...ts.freedesktop.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] drm for 6.18-rc1

On Tue, Oct 7, 2025 at 8:35 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Although that example actually made me go "WTF?" regardless of the
> changes involved.
>
> I clearly do not understand the sorting rules either. Why are the
> "device::" entries not sorted?

Essentially, `self` (a special case) is placed first, then it puts
things like modules (i.e. `lower_case`), then things like types (i.e.
`CamelCase`), and then things like constants (i.e. `UPPERCASE`):

    use crate::{
        self, myitem1,
        myitem1::{myitem2, MyItem2, MYITEM2},
        myitem3, MyItem1,
        MyItem1::{myitem2, MyItem2, MYITEM2},
        MyItem3, MYITEM1,
        MYITEM1::{myitem2, MyItem2, MYITEM2},
        MYITEM3,
    };

This got substantially changed for the next edition (2024), though --
they decided to just do version sorting (I added a 256 to show that
too):

    use crate::{
        self, MYITEM1,
        MYITEM1::{MYITEM2, MyItem2, myitem2},
        MYITEM3, MyItem1,
        MyItem1::{MYITEM2, MyItem2, myitem2},
        MyItem3, myitem1,
        myitem1::{MYITEM2, MyItem2, myitem2},
        myitem3, myitem256,
    };

https://github.com/rust-lang/rust/issues/123800

You can play with the new one in Compiler Explorer (right-click ->
Format Document).

Cheers,
Miguel