linux-kernel - Re: [PATCH] drm/nouveau: fix bad ret code in nouveau_bo_move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251007195233.GA154142@pevik>
Date: Tue, 7 Oct 2025 21:52:33 +0200
From: Petr Vorel <pvorel@...e.cz>
To: Shuhao Fu <sfual@....ust.hk>
Cc: Lyude Paul <lyude@...hat.com>, Danilo Krummrich <dakr@...nel.org>,
	dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, Ben Skeggs <bskeggs@...dia.com>
Subject: Re: [PATCH] drm/nouveau: fix bad ret code in nouveau_bo_move_prep

Hi,

[ Cc Ben ]

> In `nouveau_bo_move_prep`, if `nouveau_mem_map` fails, an error code
> should be returned. Currently, it returns zero even if vmm addr is not
> correctly mapped.

> Signed-off-by: Shuhao Fu <sfual@....ust.hk>
> Fixes: 9ce523cc3bf2 ("drm/nouveau: separate buffer object backing memory from nvkm structures")
> ---
>  drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index b96f0555ca14..f26562eafffc 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -929,7 +929,7 @@ nouveau_bo_move_prep(struct nouveau_drm *drm, struct ttm_buffer_object *bo,
>  		nvif_vmm_put(vmm, &old_mem->vma[1]);
>  		nvif_vmm_put(vmm, &old_mem->vma[0]);
>  	}
> -	return 0;
> +	return ret;

LGTM.
Reviewed-by: Petr Vorel <pvorel@...e.cz>

Kind regards,
Petr