linux-kernel - Re: [PATCH v2 1/1] hung_task: fix warnings caused by unaligned lock pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251007135600.6fc4a031c60b1384dffaead1@linux-foundation.org>
Date: Tue, 7 Oct 2025 13:56:00 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, Finn Thain
 <fthain@...ux-m68k.org>, Lance Yang <lance.yang@...ux.dev>,
 amaindex@...look.com, anna.schumaker@...cle.com, boqun.feng@...il.com,
 ioworker0@...il.com, joel.granados@...nel.org, jstultz@...gle.com,
 leonylgao@...cent.com, linux-kernel@...r.kernel.org,
 linux-m68k@...ts.linux-m68k.org, longman@...hat.com, mhiramat@...nel.org,
 mingo@...hat.com, mingzhe.yang@...com, oak@...sinkinet.fi,
 peterz@...radead.org, rostedt@...dmis.org, senozhatsky@...omium.org,
 tfiga@...omium.org, will@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/1] hung_task: fix warnings caused by unaligned lock
 pointers


Getting back to the $Subject at hand, are people OK with proceeding
with Lance's original fix?


From: Lance Yang <lance.yang@...ux.dev>
Subject: hung_task: fix warnings caused by unaligned lock pointers
Date: Tue, 9 Sep 2025 22:52:43 +0800

From: Lance Yang <lance.yang@...ux.dev>

The blocker tracking mechanism assumes that lock pointers are at least
4-byte aligned to use their lower bits for type encoding.

However, as reported by Eero Tamminen, some architectures like m68k
only guarantee 2-byte alignment of 32-bit values. This breaks the
assumption and causes two related WARN_ON_ONCE checks to trigger.

To fix this, the runtime checks are adjusted to silently ignore any lock
that is not 4-byte aligned, effectively disabling the feature in such
cases and avoiding the related warnings.

Thanks to Geert Uytterhoeven for bisecting!

Link: https://lkml.kernel.org/r/20250909145243.17119-1-lance.yang@linux.dev
Fixes: e711faaafbe5 ("hung_task: replace blocker_mutex with encoded blocker")
Signed-off-by: Lance Yang <lance.yang@...ux.dev>
Reported-by: Eero Tamminen <oak@...sinkinet.fi>
Closes: https://lore.kernel.org/lkml/CAMuHMdW7Ab13DdGs2acMQcix5ObJK0O2dG_Fxzr8_g58Rc1_0g@mail.gmail.com
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc: Anna Schumaker <anna.schumaker@...cle.com>
Cc: Boqun Feng <boqun.feng@...il.com>
Cc: Finn Thain <fthain@...ux-m68k.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Joel Granados <joel.granados@...nel.org>
Cc: John Stultz <jstultz@...gle.com>
Cc: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: Lance Yang <lance.yang@...ux.dev>
Cc: Mingzhe Yang <mingzhe.yang@...com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: Tomasz Figa <tfiga@...omium.org>
Cc: Waiman Long <longman@...hat.com>
Cc: Will Deacon <will@...nel.org>
Cc: Yongliang Gao <leonylgao@...cent.com>
Cc: <stable@...r.kernel.org>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 include/linux/hung_task.h |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

--- a/include/linux/hung_task.h~hung_task-fix-warnings-caused-by-unaligned-lock-pointers
+++ a/include/linux/hung_task.h
@@ -20,6 +20,10 @@
  * always zero. So we can use these bits to encode the specific blocking
  * type.
  *
+ * Note that on architectures where this is not guaranteed, or for any
+ * unaligned lock, this tracking mechanism is silently skipped for that
+ * lock.
+ *
  * Type encoding:
  * 00 - Blocked on mutex			(BLOCKER_TYPE_MUTEX)
  * 01 - Blocked on semaphore			(BLOCKER_TYPE_SEM)
@@ -45,7 +49,7 @@ static inline void hung_task_set_blocker
 	 * If the lock pointer matches the BLOCKER_TYPE_MASK, return
 	 * without writing anything.
 	 */
-	if (WARN_ON_ONCE(lock_ptr & BLOCKER_TYPE_MASK))
+	if (lock_ptr & BLOCKER_TYPE_MASK)
 		return;
 
 	WRITE_ONCE(current->blocker, lock_ptr | type);
@@ -53,8 +57,6 @@ static inline void hung_task_set_blocker
 
 static inline void hung_task_clear_blocker(void)
 {
-	WARN_ON_ONCE(!READ_ONCE(current->blocker));
-
 	WRITE_ONCE(current->blocker, 0UL);
 }
 
_