[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251007212325.GA160168@pevik>
Date: Tue, 7 Oct 2025 23:23:25 +0200
From: Petr Vorel <pvorel@...e.cz>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Alexandr Sapozhnkiov <alsp705@...il.com>,
Jani Nikula <jani.nikula@...ux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Tvrtko Ursulin <tursulin@...ulin.net>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
lvc-project@...uxtesting.org
Subject: Re: [PATCH 5.10] gpu/i915: fix error return in mmap_offset_attach()
> Hi,
> On Thu, Oct 02, 2025 at 11:48:26AM +0300, Alexandr Sapozhnkiov wrote:
> > From: Alexandr Sapozhnikov <alsp705@...il.com>
> > In the drm_vma_node_allow function, kmalloc may
> > return NULL, in which case the file element will not be
> > added to the mmo->vma_node list. It would be good to
> > not ignore this event, but at least log an error message.
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > Signed-off-by: Alexandr Sapozhnikov <alsp705@...il.com>
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> > index a2195e28b625..adaef8f09d59 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> > @@ -706,8 +706,11 @@ mmap_offset_attach(struct drm_i915_gem_object *obj,
> > mmo = insert_mmo(obj, mmo);
> > GEM_BUG_ON(lookup_mmo(obj, mmap_type) != mmo);
> > out:
> > - if (file)
> > - drm_vma_node_allow_once(&mmo->vma_node, file);
> > + if (file) {
> > + err = drm_vma_node_allow_once(&mmo->vma_node, file);
> > + if (err)
> > + goto err;
> > + }
> NACK here! You have received several reviews on this patch and
> didn't react to them. Please, read carefully the reviews you
> received and send a second version of the patch.
> Please do use versioning properly in your title and add a
> changelog.
> Before sending patches, please read the documentation[*].
> Andi
> [*] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
Maybe read the latest version.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Kind regards,
Petr
> > return mmo;
> > err:
> > --
> > 2.43.0
Powered by blists - more mailing lists