[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aOWQR9H2i4J8dZZR@gourry-fedora-PF4VCD3F>
Date: Tue, 7 Oct 2025 18:12:23 -0400
From: Gregory Price <gourry@...rry.net>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-mm@...ck.org, corbet@....net, muchun.song@...ux.dev,
osalvador@...e.de, david@...hat.com, hannes@...xchg.org,
laoar.shao@...il.com, brauner@...nel.org, mclapinski@...gle.com,
joel.granados@...nel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, Mel Gorman <mgorman@...e.de>,
Michal Hocko <mhocko@...e.com>,
Alexandru Moise <00moses.alexander00@...il.com>,
Mike Kravetz <mike.kravetz@...cle.com>,
David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH] Revert "mm, hugetlb: remove hugepages_treat_as_movable
sysctl"
On Tue, Oct 07, 2025 at 02:59:55PM -0700, Andrew Morton wrote:
> On Tue, 7 Oct 2025 17:44:12 -0400 Gregory Price <gourry@...rry.net> wrote:
>
> > This reverts commit d6cb41cc44c63492702281b1d329955ca767d399.
>
> It's been seven years. Perhaps "reintroduce hugepages_treat_as_movable
> sysctl" would be a better way of presenting this. Not very important.
>
But a blink of an eye! Will fix it up if feedback is positive.
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -55,6 +55,8 @@
> > #include "hugetlb_cma.h"
> > #include <linux/page-isolation.h>
> >
> > +int hugepages_treat_as_movable;
> > +
> > int hugetlb_max_hstate __read_mostly;
> > unsigned int default_hstate_idx;
> > struct hstate hstates[HUGE_MAX_HSTATE];
>
> Could sprinkle some more __read_mostlys around here?
>
Makes sense, will take a look while I'm poking around.
Thanks Andrew!
~Gregory
Powered by blists - more mailing lists