[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7476a26d-c629-49a4-ab47-eaffda482782@gmail.com>
Date: Mon, 6 Oct 2025 22:59:14 -0700
From: Rudraksha Gupta <guptarud@...il.com>
To: Diederik de Haas <didi.debian@...ow.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
Ondrej Jirman <megi@....cz>, Martijn Braam <martijn@...xit.nl>,
Kamil Trzciński <ayufan@...fan.eu>
Subject: Re: [PATCH v4 1/4] arm64: dts: rk3399-pinephone-pro: Add
light/proximity sensor support
Hello Diederik,
>> + stk3311 {
>> + stk3311_int: stk3311-int {
>> + rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_input_pull_up>;
> On page 11 and 17 of PPP schematic V1.0-20211127 I see LIGHT_INT_L as
> identifier so it's best to use that identifier here, thus
> ``light_int_l: light-int-l {``
> and update the pinctrl-0 reference accordingly.
Thanks! Since this is a simple change, I will wait for more comments in
this patch series (would like comments on the mount matrices for the
accelerometer and the magnetometer). I will put this change in v5 if I
send one.
Thanks,
Rudraksha
Powered by blists - more mailing lists