[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bc223eabf97d4c530a43c4831fe6ba2be7ae43b9.camel@mediatek.com>
Date: Tue, 7 Oct 2025 07:02:18 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "avri.altman@....com" <avri.altman@....com>, "quic_cang@...cinc.com"
<quic_cang@...cinc.com>, "quic_nitirawa@...cinc.com"
<quic_nitirawa@...cinc.com>, "quic_nguyenb@...cinc.com"
<quic_nguyenb@...cinc.com>, "manivannan.sadhasivam@...aro.org"
<manivannan.sadhasivam@...aro.org>, "bvanassche@....org"
<bvanassche@....org>, "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
"martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC: "beanhuo@...ron.com" <beanhuo@...ron.com>, "chu.stanley@...il.com"
<chu.stanley@...il.com>, "quic_mapa@...cinc.com" <quic_mapa@...cinc.com>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "AngeloGioacchino
Del Regno" <angelogioacchino.delregno@...labora.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
<matthias.bgg@...il.com>, "James.Bottomley@...senPartnership.com"
<James.Bottomley@...senPartnership.com>, "mani@...nel.org" <mani@...nel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v1 1/2] scsi: ufs: core: Remove
UFS_DEVICE_QUIRK_DELAY_AFTER_LPM quirk
On Fri, 2025-10-03 at 14:11 -0700, Bao D. Nguyen wrote:
> Are you referring to the always_on flag in the struct ufs_vreg? I
> believe currently the ufs_vreg's always_on flag isn't used in
> determining whether the delay is applied or not.
>
Hi Bao,
Yes, I mean vreg_info.vcc->always_on = true.
Before your change, Mediatek would set always_on = true
and remove UFS_DEVICE_QUIRK_DELAY_AFTER_LPM to disable
this delay.
> How about we add the check for the Vcc's always_on as shown below?
> The Mediatek's workaround can avoid the extra delay by setting the
> always_on flag as it already did, without using the
> UFS_DEVICE_QUIRK_DELAY_AFTER_LPM.
>
> if (vcc_off && hba->vreg_info.vcc && !hba->vreg_info.vcc->always_on)
> usleep_range(5000, 5100);
>
> Thanks, Bao
>
>
Yes, I believe this is the correct way to do it.
Thanks
Peter
Powered by blists - more mailing lists