linux-kernel - Re: [PATCH v3] drm/gud: Use kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d087a2c8-05f6-4fc1-924a-c3a84eae119c@gmail.com>
Date: Tue, 7 Oct 2025 10:00:53 +0100
From: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>
To: Thomas Zimmermann <tzimmermann@...e.de>,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, airlied@...il.com,
 simona@...ll.ch, mingo@...nel.org, tglx@...utronix.de, jfalempe@...hat.com
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org, david.hunter.linux@...il.com, khalid@...nel.org,
 rubenru09@....com, linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v3] drm/gud: Use kmalloc_array() instead of kmalloc()

On 10/7/25 9:58 AM, Thomas Zimmermann wrote:
> Hi
> 
> Am 07.10.25 um 10:32 schrieb Mehdi Ben Hadj Khelifa:
>> Replace kmalloc with kmalloc array in drm/gud/gud_pipe.c since the
>> calculation inside kmalloc is dynamic 'width * height'
>>
>> Signed-off-by: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@...il.com>
> 
> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>
> 
> As Ruben already acked the previous patch, you should add such acks to 
> any later patches. But no need to resend a new iteration now. I'll add 
> Ruben's a-b when I merge the patch.

ack,I forgot about that. Thanks for the heads-up.We'll do next time!

> Best regards
> Thomas

Best Regards,
Mehdi Ben Hadj Khelifa

>> ---
>> Changelog:
>>
>> Changes since v2:
>> -Reversed width and height in parameter order.
>> Link:https://lore.kernel.org/all/20250923085144.22582-1- 
>> mehdi.benhadjkhelifa@...il.com/
>> Changes since v1:
>> - Use of width as element count and height as size of element to
>> eliminate the mentionned calculation and overflow issues.
>> Link:https://lore.kernel.org/all/20250922174416.226203-1- 
>> mehdi.benhadjkhelifa@...il.com/
>>   drivers/gpu/drm/gud/gud_pipe.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/ 
>> gud_pipe.c
>> index 8d548d08f127..c32a798ccadf 100644
>> --- a/drivers/gpu/drm/gud/gud_pipe.c
>> +++ b/drivers/gpu/drm/gud/gud_pipe.c
>> @@ -70,7 +70,7 @@ static size_t gud_xrgb8888_to_r124(u8 *dst, const 
>> struct drm_format_info *format
>>       height = drm_rect_height(rect);
>>       len = drm_format_info_min_pitch(format, 0, width) * height;
>> -    buf = kmalloc(width * height, GFP_KERNEL);
>> +    buf = kmalloc_array(height, width, GFP_KERNEL);
>>       if (!buf)
>>           return 0;
>