[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251007011649.GA706748-robh@kernel.org>
Date: Mon, 6 Oct 2025 20:16:49 -0500
From: Rob Herring <robh@...nel.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, jessica.zhang@....qualcomm.com,
airlied@...il.com, simona@...ll.ch,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, krzk+dt@...nel.org, conor+dt@...nel.org,
dianders@...omium.org, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: display: panel: Add Tianma
TL121BVMS07-00 panel
On Tue, Sep 30, 2025 at 03:50:43PM +0800, Langyan Ye wrote:
> Add device tree bindings for the Tianma TL121BVMS07-00 12.1"
> MIPI-DSI TFT LCD panel.
>
> Signed-off-by: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> ---
> .../display/panel/tianma,tl121bvms07-00.yaml | 85 +++++++++++++++++++
> 1 file changed, 85 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,tl121bvms07-00.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/tianma,tl121bvms07-00.yaml b/Documentation/devicetree/bindings/display/panel/tianma,tl121bvms07-00.yaml
> new file mode 100644
> index 000000000000..e654b86782e6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/tianma,tl121bvms07-00.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/tianma,tl121bvms07-00.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Tianma TL121BVMS07-00 12.1" MIPI-DSI TFT LCD Panel
> +
> +maintainers:
> + - Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> +
> +description: |
Don't need '|' if no formatting to preserve.
> + The Tianma TL121BVMS07-00 is a 12.1-inch MIPI-DSI TFT LCD panel.
> + It requires multiple regulators (AVDD, AVEE, and 1.8V logic)
> + and an enable GPIO. Optional properties such as backlight and
> + rotation are inherited from panel-common.yaml.
Wrap lines at 80 char. The last sentence can be dropped as it says what
the schema do.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: tianma,tl121bvms07-00
> +
> + reg:
> + description: DSI virtual channel number
> + minimum: 0
> + maximum: 3
Just 'reg: true'. dsi-controller.yaml already has these constraints.
> +
> + enable-gpios:
> + maxItems: 1
> + description: GPIO specifier for the enable pin
> +
> + avdd-supply:
> + description: phandle of the regulator that provides positive voltage
> +
> + avee-supply:
> + description: phandle of the regulator that provides negative voltage
> +
> + pp1800-supply:
> + description: core voltage supply
> +
> + backlight:
> + $ref: /schemas/types.yaml#/definitions/phandle
Already has a type in panel-common.yaml. Drop.
> + description: Phandle to the backlight device.
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Input port of the panel, connected to the DSI host.
Already in panel-common.yaml.
Either just 'true' for both of these or drop and use
'unevaluatedProperties' instead of 'additionalProperties'.
> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - avdd-supply
> + - avee-supply
> + - pp1800-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dsi0 {
dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mipi_panel: panel@0 {
drop unused labels.
> + compatible = "tianma,tl121bvms07-00";
> + reg = <0>;
> + enable-gpios = <&pio 25 0>;
> + avdd-supply = <&en_pp5800_mipi_disp>;
> + avee-supply = <&en_pp5800_mipi_disp>;
> + pp1800-supply = <&mt6359_vcn18_ldo_reg>;
> + backlight = <&backlight>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&dsi_out>;
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.34.1
>
Powered by blists - more mailing lists